call ValidateBasic on SlashPacket

cosmos · Dec 23, 2022 · f30ecf6 · f30ecf6
1 parent b61ce3b
commit f30ecf6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/x/ccv/provider/keeper/relay.go b/x/ccv/provider/keeper/relay.go
@@ -296,6 +296,10 @@ func (k Keeper) OnRecvSlashPacket(ctx sdk.Context, packet channeltypes.Packet, d
 func (k Keeper) ValidateSlashPacket(ctx sdk.Context, chainID string,
 	packet channeltypes.Packet, data ccv.SlashPacketData) error {
 
+	if err := data.ValidateBasic(); err != nil {
+		return err
+	}
+
 	// return error if we cannot find infraction height matching the validator update id
 	if _, found := k.getMappedInfractionHeight(ctx, chainID, data.ValsetUpdateId); !found {
 		return providertypes.ErrSlashPacketInfractionHeightInvalid

diff --git a/x/ccv/provider/types/errors.go b/x/ccv/provider/types/errors.go
@@ -19,5 +19,4 @@ var (
 	ErrInvalidConsumerParams              = sdkerrors.Register(ModuleName, 11, "invalid consumer params")
 	ErrSlashPacketInfractionHeightInvalid = sdkerrors.Register(ModuleName, 12, "cannot find infraction height")
 	ErrSlashPacketInfractionTypeInvalid   = sdkerrors.Register(ModuleName, 13, "infraction type invalid")
-	ErrSlashPacketOutdated                = sdkerrors.Register(ModuleName, 14, "slash packet out of date")
 )