fix: remove validation for provider chain address since we cannot val…

…idate it properly on consumer
cosmos · Sep 5, 2023 · 1b5183c · 1b5183c
1 parent 6da7fef
commit 1b5183c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/x/ccv/consumer/types/params_test.go b/x/ccv/consumer/types/params_test.go
@@ -29,10 +29,6 @@ func TestValidateParams(t *testing.T) {
 			"custom invalid params, dist transmission channel",
 			ccvtypes.NewParams(true, 5, "badchannel/", "", 5, 1005, "0.5", 1000, 24*21*time.Hour, "0.05", []string{"untrn"}, []string{"uatom"}), false,
 		},
-		{
-			"custom invalid params, provider fee pool addr string",
-			ccvtypes.NewParams(true, 5, "", "imabadaddress", 5, 1005, "0.5", 1000, 24*21*time.Hour, "0.05", []string{"untrn"}, []string{"uatom"}), false,
-		},
 		{
 			"custom invalid params, ccv timeout",
 			ccvtypes.NewParams(true, 5, "", "", -5, 1005, "0.5", 1000, 24*21*time.Hour, "0.05", []string{"untrn"}, []string{"uatom"}), false,

diff --git a/x/ccv/types/params.go b/x/ccv/types/params.go
@@ -179,8 +179,8 @@ func ValidateProviderFeePoolAddrStr(i interface{}) error {
 	if i == "" {
 		return nil
 	}
-	// Otherwise validate as usual for a bech32 address
-	return ValidateBech32(i)
+	// Cannot validate provider chain address on the consumer chain
+	return nil
 }
 
 func ValidateSoftOptOutThreshold(i interface{}) error {