feat: add stricter checks for iavl spec and tendermint spec #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Damian Nolan <[email protected]>
…23 into colin/deobfuscate-dragonberry
colin-axner
changed the title
colin-axner
commented
Oct 17, 2024
| @@ -75,6 +84,26 @@ func validateIavlOps(op opType, layerNum int) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // validateTendermintOps validates the prefix to ensure it begins with []byte{1}. | |||
| func validateTendermintOps(op *InnerOp) error { | |||
There was a problem hiding this comment.
Adding for any future reader context.
In store/v2, the same thing is happening here in ProofFromByteSlices ref
…into colin/stricter-iavl-checks
damiannolan
approved these changes
Oct 21, 2024
| @@ -75,6 +84,26 @@ func validateIavlOps(op opType, layerNum int) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // validateTendermintOps validates the prefix to ensure it begins with []byte{1}. | |||
| func validateTendermintOps(op *InnerOp) error { | |||
There was a problem hiding this comment.
Adding for any future reader context.
In store/v2, the same thing is happening here in ProofFromByteSlices ref
AdityaSripal
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.