Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: avoid cloning and use .map/.entry in Rust code #181

Merged
merged 1 commit into from
Sep 5, 2023
Merged

chore: avoid cloning and use .map/.entry in Rust code #181

merged 1 commit into from
Sep 5, 2023

Conversation

kevinji
Copy link
Contributor

@kevinji kevinji commented Aug 27, 2023

There's no functional changes, just some code cleanup.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 95.94% and project coverage change: +16.60% 🎉

Comparison is base (7b1588b) 48.76% compared to head (1465773) 65.36%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #181       +/-   ##
===========================================
+ Coverage   48.76%   65.36%   +16.60%     
===========================================
  Files          23        7       -16     
  Lines        9899     3560     -6339     
  Branches       86        0       -86     
===========================================
- Hits         4827     2327     -2500     
+ Misses       4715     1233     -3482     
+ Partials      357        0      -357     
Flag Coverage Δ
go ?
rust 65.36% <95.94%> (+0.04%) ⬆️
typescript ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
rust/src/compress.rs 96.87% <95.12%> (-0.05%) ⬇️
rust/src/api.rs 97.25% <95.45%> (+0.03%) ⬆️
rust/src/verify.rs 94.76% <100.00%> (-0.13%) ⬇️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

@romac romac merged commit 9f86b67 into cosmos:master Sep 5, 2023
7 checks passed
@kevinji kevinji deleted the clean-up-rust branch September 5, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants