Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade go #162

Merged
merged 4 commits into from
Sep 15, 2023
Merged

chore: upgrade go #162

merged 4 commits into from
Sep 15, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Aug 24, 2023

This PR upgrades Go in ics23.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -18.42% ⚠️

Comparison is base (e179fae) 56.63% compared to head (afe3b88) 38.22%.
Report is 1 commits behind head on master.

❗ Current head afe3b88 differs from pull request most recent head 0e03cbb. Consider uploading reports for the commit 0e03cbb to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #162       +/-   ##
===========================================
- Coverage   56.63%   38.22%   -18.42%     
===========================================
  Files          18        5       -13     
  Lines        5689     4220     -1469     
  Branches       86        0       -86     
===========================================
- Hits         3222     1613     -1609     
+ Misses       2424     2293      -131     
- Partials       43      314      +271     
Flag Coverage Δ
go 38.22% <ø> (?)
rust ?
typescript ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@faddat faddat changed the title deps: upgrade go chore: upgrade go Aug 24, 2023
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making this pr,

@tac0turtle
Copy link
Member

go lint is failing, could you fix this and then should be good to merge

@crodriguezvega crodriguezvega merged commit 9a555c4 into cosmos:master Sep 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants