Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint ics23 golang code #161

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Aug 24, 2023

This PR lints the Go code in ics23.

It also contains bumps to gogoproto and golang itself, which will be submitted in separate PR's for
isolation.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 52.00% and project coverage change: -18.54% ⚠️

Comparison is base (e179fae) 56.63% compared to head (a791f31) 38.09%.

❗ Current head a791f31 differs from pull request most recent head f7b891a. Consider uploading reports for the commit f7b891a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #161       +/-   ##
===========================================
- Coverage   56.63%   38.09%   -18.54%     
===========================================
  Files          18        5       -13     
  Lines        5689     4231     -1458     
  Branches       86        0       -86     
===========================================
- Hits         3222     1612     -1610     
+ Misses       2424     2301      -123     
- Partials       43      318      +275     
Flag Coverage Δ
go 38.09% <52.00%> (?)
rust ?
typescript ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
go/ops.go 65.19% <42.85%> (ø)
go/compress.go 96.72% <100.00%> (ø)
go/proof.go 59.34% <100.00%> (ø)

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@faddat faddat changed the title lint ics23 golang code chore: lint ics23 golang code Aug 24, 2023
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @faddat!

@crodriguezvega crodriguezvega merged commit 5f9fbd8 into cosmos:master Sep 15, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants