-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: lint ics23 golang code #161
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
===========================================
- Coverage 56.63% 38.09% -18.54%
===========================================
Files 18 5 -13
Lines 5689 4231 -1458
Branches 86 0 -86
===========================================
- Hits 3222 1612 -1610
+ Misses 2424 2301 -123
- Partials 43 318 +275
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @faddat!
This PR lints the Go code in ics23.
It also contains bumps to gogoproto and golang itself, which will be submitted in separate PR's for
isolation.