ICS30: Update callbacks #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpoke
approved these changes
Jul 7, 2022
| @@ -101,6 +108,12 @@ function onChanOpenInit( | |||
| counterpartyChannelIdentifier, | |||
| appVersion, // note we only pass app version here | |||
| ) | |||
| abortTransactionUnless(err != nil) | |||
There was a problem hiding this comment.
If we call abortTransactionUnless here, is there a reason to return Error?
There was a problem hiding this comment.
This is true, but I'm just trying to stay consistent with the ICS26 function signature. In practice, the abortTransaction process is carried out by returning an error at this level.
| @@ -130,6 +144,12 @@ function OnChanOpenTry( | |||
| cpAppVersion, // note we only pass counterparty app version here | |||
| appVersion, // only pass app version | |||
| ) | |||
| abortTransactionUnless(err != nil) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update based on #629