ICS27: fix calls to set active channel ID and some style improvements #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
AdityaSripal,
cwgoes,
colin-axner and
angbrav
as code owners
crodriguezvega
commented
Aug 19, 2023
| @@ -5,7 +5,7 @@ stage: Draft | |||
| category: IBC/APP | |||
| requires: 25, 26 | |||
| kind: instantiation | |||
| version compatibility: ibc-go v7.0.0 | |||
| version compatibility: | |||
There was a problem hiding this comment.
Removed because channel upgrade callbacks were added.
Comment on lines
+359
to
+364
| onChanUpgradeInit, | ||
| onChanUpgradeTry, | ||
| onChanUpgradeAck, | ||
| onChanUpgradeConfirm, | ||
| onChanUpgradeOpen, | ||
| onChanUpgradeRestore, |
There was a problem hiding this comment.
I forgot adding this in #1007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.