Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ibc-proto-rs to v0.39.1 #994

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Conversation

seanchen1991
Copy link
Contributor

Part of: #993

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (8f2ddfe) 70.76% compared to head (6ee2c85) 70.63%.

Files Patch % Lines
ibc-query/src/core/channel/query.rs 0.00% 26 Missing ⚠️
ibc-query/src/core/channel/service.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
- Coverage   70.76%   70.63%   -0.13%     
==========================================
  Files         178      178              
  Lines       17943    17976      +33     
==========================================
  Hits        12698    12698              
- Misses       5245     5278      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's apply the followings, then we're good to go. Thanks.

  • Update ibc-proto-rs in the ci/no-std-check crate too.
  • Add a unclog

@Farhad-Shabani Farhad-Shabani added this to the v0.49.0 milestone Nov 28, 2023
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@Farhad-Shabani Farhad-Shabani merged commit f306667 into main Nov 28, 2023
14 checks passed
@Farhad-Shabani Farhad-Shabani deleted the sean/update-ibc-proto-rs branch November 28, 2023 19:37
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
* Update ibc-proto-rs to v0.39.1

* Update ci/no-std-check to ibc-proto-rs v0.39.1

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants