-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: restructure ibc
crate
#975
Merged
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
68b4ca6
feat: migrate `applications` module under the `ibc` crate into `ibc-a…
Farhad-Shabani 55038aa
docs: ADR-008 to restructure the `ibc` crate (#966)
Farhad-Shabani 3cc9753
feat: migrate `core`, `clients` modules into `ibc-core`, `ibc-clients…
Farhad-Shabani d8cf526
imp: move crates into the root directory
Farhad-Shabani 8307b7c
chore: add unclogs + fix broken links
Farhad-Shabani 38335e6
fix: additional deps and features adjustment
Farhad-Shabani 42d4c2e
fix: cargo fmt, clippy
Farhad-Shabani 90c5633
imp: review ibc-core-host-cosmos crate
Farhad-Shabani db42ee2
fix: move consensus_state API implementation into ibc-client-tendermint
Farhad-Shabani ab83bfb
Delete empty ics07-tendermint/types README
seanchen1991 19b945c
fix: apply suggestions from code review
Farhad-Shabani fdf8ba1
fix: adjust comments, markdowns
Farhad-Shabani a8e22b7
nit: further touchups
Farhad-Shabani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
3 changes: 3 additions & 0 deletions
3
...eaking-changes/716-move-transfer-app-and-tendermint-client-to-separate-crate.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
- Move ICS-20 and ICS-27 implementations to the respective part of `ibc-apps` | ||
and `ibc-clients` crates, as part of the `ibc` crate restructuring effort. | ||
([\#716](https://github.com/cosmos/ibc-rs/issues/716)) |
5 changes: 5 additions & 0 deletions
5
.changelog/unreleased/breaking-changes/965-restructure-ibc.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
- Restructure `ibc-rs` codebase by organizing it into smaller self-contained, | ||
modular libraries, enabling the selective import of specific domain types or | ||
module implementations, either individually or in combination, providing | ||
enhanced flexibility and ease of use. | ||
([\#965](https://github.com/cosmos/ibc-rs/issues/965)) |
3 changes: 3 additions & 0 deletions
3
.changelog/unreleased/improvements/697-re-export-essential-proto-types.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
- Re-export essential proto types from the underlying `ibc-*-*-types` crates, | ||
removing the necessity for a direct dependency on `ibc-proto` in projects | ||
integrating `ibc-rs` ([\#697](https://github.com/cosmos/ibc-rs/issues/697)) |
2 changes: 2 additions & 0 deletions
2
.changelog/unreleased/improvements/771-use-mod-rs-places-having-submodules.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
- Rename `{submodule}.rs` with corresponding `{submodule}` directory to | ||
`{submodule}/mod.rs` ([\#771](https://github.com/cosmos/ibc-rs/issues/771)) |
2 changes: 2 additions & 0 deletions
2
.changelog/unreleased/improvements/948-remove-redundant-test-log-deps.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
- Remove redundant `#[test_log::test]` attributes in test modules | ||
([\#948](https://github.com/cosmos/ibc-rs/issues/948)) |
File renamed without changes.
6 changes: 6 additions & 0 deletions
6
.changelog/unreleased/improvements/976-expose-different-types-for-public-access.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
- Expose various fields, types and functions in `ibc-rs` as public including: | ||
- `validate` and `execute` handler functions for all the IBC message types. | ||
- `TYPE_URL` constants. | ||
- Any private fields within the domain message types. | ||
- Any private fields within the Tendermint `ClientState` and `ConsensusState` | ||
([\#976](https://github.com/cosmos/ibc-rs/issues/976)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,33 @@ | ||
[workspace] | ||
resolver = "2" | ||
members = [ | ||
"crates/ibc", | ||
"crates/ibc-derive", | ||
"crates/ibc-testkit", | ||
"crates/ibc-query", | ||
"ibc", | ||
"ibc-data-types", | ||
"ibc-primitives", | ||
"ibc-core", | ||
"ibc-clients", | ||
"ibc-apps", | ||
"ibc-testkit", | ||
"ibc-query", | ||
"ibc-derive", | ||
"ibc-core/ics02-client", | ||
"ibc-core/ics02-client/types", | ||
"ibc-core/ics03-connection", | ||
"ibc-core/ics03-connection/types", | ||
"ibc-core/ics04-channel", | ||
"ibc-core/ics04-channel/types", | ||
"ibc-core/ics23-commitment/types", | ||
"ibc-core/ics24-host", | ||
"ibc-core/ics24-host/types", | ||
"ibc-core/ics24-host/cosmos", | ||
"ibc-core/ics25-handler", | ||
"ibc-core/ics25-handler/types", | ||
"ibc-core/ics26-routing", | ||
"ibc-core/ics26-routing/types", | ||
"ibc-clients/ics07-tendermint", | ||
"ibc-clients/ics07-tendermint/types", | ||
"ibc-apps/ics20-transfer", | ||
"ibc-apps/ics20-transfer/types", | ||
] | ||
exclude = [ | ||
"ci/cw-check", | ||
|
@@ -22,41 +45,62 @@ authors = ["Informal Systems <[email protected]>"] | |
|
||
[workspace.dependencies] | ||
# external dependencies | ||
borsh = {version = "0.10", default-features = false } | ||
bytes = { version = "1.5.0", default-features = false } | ||
displaydoc = { version = "0.2", default-features = false } | ||
derive_more = { version = "0.99.17", default-features = false, features = ["from", "into", "display", "try_into"] } | ||
env_logger = "0.10.0" | ||
num-traits = { version = "0.2.17", default-features = false } | ||
parking_lot = { version = "0.12.1", default-features = false } | ||
primitive-types = { version = "0.12.2", default-features = false, features = ["serde_no_std"] } | ||
prost = { version = "0.12", default-features = false } | ||
rstest = "0.18.2" | ||
schemars = { version = "0.8.15"} | ||
sha2 = { version = "0.10.8", default-features = false } | ||
serde = { version = "1.0", default-features = false } | ||
serde_derive = { version = "1.0", default-features = false } | ||
serde_json = { package = "serde-json-wasm", version = "1.0.0" , default-features = false } | ||
subtle-encoding = { version = "0.5", default-features = false } | ||
test-log = { version = "0.2.13", features = ["trace"] } | ||
time = { version = ">=0.3.0, <0.3.31", default-features = false } | ||
tracing = { version = "0.1.40", default-features = false } | ||
tracing-subscriber = { version = "0.3.17", features = ["fmt", "env-filter", "json"] } | ||
typed-builder = { version = "0.18.0"} | ||
borsh = { version = "0.10", default-features = false } | ||
bytes = { version = "1.5.0", default-features = false } | ||
displaydoc = { version = "0.2", default-features = false } | ||
derive_more = { version = "0.99.17", default-features = false, features = ["from", "into", "display", "try_into"] } | ||
num-traits = { version = "0.2.17", default-features = false } | ||
primitive-types = { version = "0.12.2", default-features = false, features = ["serde_no_std"] } | ||
prost = { version = "0.12", default-features = false } | ||
rstest = "0.18.2" | ||
schemars = { version = "0.8.15" } | ||
sha2 = { version = "0.10.8", default-features = false } | ||
serde = { version = "1.0", default-features = false } | ||
serde_json = { package = "serde-json-wasm", version = "1.0.0" , default-features = false } | ||
subtle-encoding = { version = "0.5", default-features = false } | ||
time = { version = ">=0.3.0, <0.3.31", default-features = false } | ||
|
||
# ibc dependencies | ||
ibc-derive = { version = "0.3.0", path = "../ibc-derive" } | ||
ibc = { version = "0.47.0", path = "./ibc", default-features = false } | ||
ibc-core = { version = "0.47.0", path = "./ibc-core", default-features = false } | ||
ibc-clients = { version = "0.47.0", path = "./ibc-clients", default-features = false } | ||
ibc-apps = { version = "0.47.0", path = "./ibc-apps", default-features = false } | ||
ibc-primitives = { version = "0.47.0", path = "./ibc-primitives", default-features = false } | ||
ibc-testkit = { version = "0.47.0", path = "./ibc-testkit" } | ||
ibc-derive = { version = "0.3.0", path = "./ibc-derive" } | ||
|
||
ibc-core-client = { version = "0.47.0", path = "./ibc-core/ics02-client", default-features = false } | ||
ibc-core-connection = { version = "0.47.0", path = "./ibc-core/ics03-connection", default-features = false } | ||
ibc-core-channel = { version = "0.47.0", path = "./ibc-core/ics04-channel", default-features = false } | ||
ibc-core-host = { version = "0.47.0", path = "./ibc-core/ics24-host", default-features = false } | ||
ibc-core-handler = { version = "0.47.0", path = "./ibc-core/ics25-handler", default-features = false } | ||
ibc-core-router = { version = "0.47.0", path = "./ibc-core/ics26-routing", default-features = false } | ||
ibc-client-tendermint = { version = "0.47.0", path = "./ibc-clients/ics07-tendermint", default-features = false } | ||
ibc-app-transfer = { version = "0.47.0", path = "./ibc-apps/ics20-transfer", default-features = false } | ||
|
||
ibc-core-client-context = { version = "0.47.0", path = "./ibc-core/ics02-client/context", default-features = false } | ||
ibc-core-client-types = { version = "0.47.0", path = "./ibc-core/ics02-client/types", default-features = false } | ||
ibc-core-channel-types = { version = "0.47.0", path = "./ibc-core/ics04-channel/types", default-features = false } | ||
ibc-core-connection-types = { version = "0.47.0", path = "./ibc-core/ics03-connection/types", default-features = false } | ||
ibc-core-commitment-types = { version = "0.47.0", path = "./ibc-core/ics23-commitment/types", default-features = false } | ||
ibc-core-host-cosmos = { version = "0.47.0", path = "./ibc-core/ics24-host/cosmos", default-features = false } | ||
ibc-core-host-types = { version = "0.47.0", path = "./ibc-core/ics24-host/types", default-features = false } | ||
ibc-core-handler-types = { version = "0.47.0", path = "./ibc-core/ics25-handler/types", default-features = false } | ||
ibc-core-router-types = { version = "0.47.0", path = "./ibc-core/ics26-routing/types", default-features = false } | ||
ibc-client-tendermint-types = { version = "0.47.0", path = "./ibc-clients/ics07-tendermint/types", default-features = false } | ||
ibc-app-transfer-types = { version = "0.47.0", path = "./ibc-apps/ics20-transfer/types", default-features = false } | ||
|
||
ibc-proto = { version = "0.38.0", default-features = false } | ||
ics23 = { version = "0.11", default-features = false } | ||
ics23 = { version = "0.11", default-features = false } | ||
|
||
# cosmos dependencies | ||
tendermint = { version = "0.34.0", default-features = false } | ||
tendermint-light-client = { version = "0.34.0", default-features = false } | ||
tendermint = { version = "0.34.0", default-features = false } | ||
tendermint-light-client = { version = "0.34.0", default-features = false } | ||
tendermint-light-client-verifier = { version = "0.34.0", default-features = false } | ||
tendermint-proto = { version = "0.34.0", default-features = false } | ||
tendermint-rpc = { version = "0.34.0", default-features = false } | ||
tendermint-testgen = { version = "0.34.0", default-features = false } | ||
tendermint-proto = { version = "0.34.0", default-features = false } | ||
tendermint-rpc = { version = "0.34.0", default-features = false } | ||
tendermint-testgen = { version = "0.34.0", default-features = false } | ||
|
||
# parity dependencies | ||
parity-scale-codec = { version = "3.6.5", default-features = false, features = ["full"] } | ||
scale-info = { version = "2.10.0", default-features = false, features = ["derive"] } | ||
scale-info = { version = "2.10.0", default-features = false, features = ["derive"] } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can do
ibc*/**
, unless you want to be selective.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, still being able to selectively comment out each crates works better for the development and debugging purposes imo.