imp: enhance dependency management with workspace inheritance #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #957 +/- ##
==========================================
- Coverage 66.39% 66.38% -0.01%
==========================================
Files 161 161
Lines 15770 15767 -3
==========================================
- Hits 10470 10467 -3
Misses 5300 5300
☔ View full report in Codecov by Sentry. |
rnbguy
requested changes
Nov 10, 2023
Co-authored-by: Rano | Ranadeep <[email protected]> Signed-off-by: Farhad Shabani <[email protected]>
rnbguy
approved these changes
Nov 10, 2023
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
* imp: use workspace dependencies * chore: add unclog * fix: clippy catches * fix: cleanups b/c of merging main branch * fix: add ibc-testkit as dev-dep to ibc * nit: reorder ibc deps * fix: apply suggestions from code review Co-authored-by: Rano | Ranadeep <[email protected]> Signed-off-by: Farhad Shabani <[email protected]> * fix: use worksapce for dev-deps under ibc-testkit --------- Signed-off-by: Farhad Shabani <[email protected]> Co-authored-by: Rano | Ranadeep <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #955
Closes: #956
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.