-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: restructure mock module and separate its codebase into a new crate #954
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #954 +/- ##
==========================================
- Coverage 67.72% 66.39% -1.33%
==========================================
Files 130 161 +31
Lines 16491 15770 -721
==========================================
- Hits 11168 10470 -698
+ Misses 5323 5300 -23
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Farhad-Shabani for taking care of this big PR. Just a few suggestions and questions.
.changelog/unreleased/improvements/951-remove-default-portid.md
Outdated
Show resolved
Hide resolved
.changelog/unreleased/improvements/952-expose-channel-message-types copy.md
Outdated
Show resolved
Hide resolved
.changelog/unreleased/features/954-restructure-mock-module-into-crate.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Rano | Ranadeep <[email protected]> Signed-off-by: Farhad Shabani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few more comments 🙂 Otherwise, I approved the PR.
This was a huge effort ! Thanks @Farhad-Shabani 🙏
…ate (#954) * imp: separate mock module into a dedicated crate * fix: clippy, fmt, no-std * imp: restructure second iteration * chore: add unclogs + update READMEs * deps: bump typed-builder * fix: move client_ctx under core * fix: cargo fmt * fix: remove tracing dep from ibc * deps: remove parking_lot from ibc * deps: remove num-traits from ibc * fix: apply suggestions from code review Co-authored-by: Rano | Ranadeep <[email protected]> Signed-off-by: Farhad Shabani <[email protected]> * nit: apply feedback * fix: introduce with_current_timestamp() * fix: cargo test * imp: move test_utils.rs into utils * imp: move test-utils + mock into the ibc-testkit * imp: add deny attr for tests * chore: cleanups * chore: add comment for ibc dep in ibc-testkit * chore: adjust paths for types imported from ibc_testkit::utils * chore: move tendermint::client_state::test_utils under the tests module * imp: replace json files under the src/data dir * chore: replace data/json under tests * imp: use concat! for paths --------- Signed-off-by: Farhad Shabani <[email protected]> Co-authored-by: Rano | Ranadeep <[email protected]>
Closes: #953
Closes: #952
Closes: #951
Description
The mock implementation has undergone a comprehensive restructuring aimed at achieving complete decoupling of its various components and organizing them under relevant categories. This should facilitate future enhancements, particularly the addition of new implementations for components such as relayers and mock chains.
This restructuring results in four distinct top-level groups as follows:
By the way, this is the first iteration and we might improve it in the future as we refactor our testing kits.
The new crate is named
ibc-testkit
, and here is an overview of its directory structure:Remark
mock
types are still maintained within theibc
crate.PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.