Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore no_std support for serde feature #790

Merged
merged 8 commits into from
Aug 23, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Jul 27, 2023

Closes: #741
Closes: #753
Closes: #838

Integration tests: informalsystems/basecoin-rs#124

Remarks


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.01% ⚠️

Comparison is base (a9cfd86) 71.48% compared to head (9a48df5) 71.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #790      +/-   ##
==========================================
- Coverage   71.48%   71.48%   -0.01%     
==========================================
  Files         124      124              
  Lines       14963    14979      +16     
==========================================
+ Hits        10696    10707      +11     
- Misses       4267     4272       +5     
Files Changed Coverage Δ
crates/ibc/src/core/handler.rs 92.22% <ø> (ø)
crates/ibc/src/core/ics02_client/error.rs 24.32% <ø> (ø)
...ibc/src/core/ics02_client/handler/update_client.rs 95.45% <ø> (ø)
...c/src/hosts/tendermint/upgrade_proposal/handler.rs 0.00% <0.00%> (ø)
...bc/src/core/ics03_connection/msgs/conn_open_ack.rs 91.91% <55.55%> (-3.69%) ⬇️
...bc/src/core/ics03_connection/msgs/conn_open_try.rs 93.65% <55.55%> (-2.96%) ⬇️
...s/ibc/src/clients/ics07_tendermint/misbehaviour.rs 68.42% <100.00%> (+0.33%) ⬆️
crates/ibc/src/core/ics02_client/msgs.rs 100.00% <100.00%> (ø)
...es/ibc/src/core/ics02_client/msgs/update_client.rs 90.00% <100.00%> (+0.71%) ⬆️
crates/ibc/src/mock/header.rs 72.00% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dzmitry-lahoda
Copy link
Contributor

this works well for me

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review August 17, 2023 18:34
@Farhad-Shabani Farhad-Shabani merged commit d8d4973 into main Aug 23, 2023
13 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/restore-no-std-support branch August 23, 2023 14:13
plafer pushed a commit that referenced this pull request Aug 30, 2023
* fix: restore no_std support for serde feature

* deps: bump ibc-proto-rs to v0.34.0

* fix: reflect changes b/c of ibc-proto-rs

* imp: comply naming + use better domain type for host_consensus_state

* fix: apply host_cons_state_proof changes for conn_open_ack

* fix: use domain TmEvent instead of proto for upgrade client proposal handler

* misc: add a unclog for ibc-proto-rs upgrade
Farhad-Shabani added a commit that referenced this pull request Dec 11, 2023
… `burn-*` methods (#836)

* split send_coins_*() functions

and introduce extra data

* arg name change

* add error variant

* add error

* add `Other` variant to `TokenTransferError`

* fmt

* fix: restore `no_std` support for `serde` feature (#790)

* fix: restore no_std support for serde feature

* deps: bump ibc-proto-rs to v0.34.0

* fix: reflect changes b/c of ibc-proto-rs

* imp: comply naming + use better domain type for host_consensus_state

* fix: apply host_cons_state_proof changes for conn_open_ack

* fix: use domain TmEvent instead of proto for upgrade client proposal handler

* misc: add a unclog for ibc-proto-rs upgrade

* bump ibc-proto to v0.34.1 and borsh to v0.10 (#844)

* bump ibc-proto and borsh

* changelog

* add borsh derive for `MsgTransfer`

* derive JsonSchema for MsgTransfer

* fix JsonSchema derive for MsgTransfer

Fix is in implementing it properly for our `Timestamp`

* execute() methods must have &mut self

* nit: spell checker

* imp: simplify escrow/unescrow abstraction + using memo instead

* chore: dress up with unclogs

* nit: adjust unlogs

* nit: remove confusing InternalTransferFailed error variant

* imp: add memo field to burn-coins-*

* docs: adjust & add missing docstrings

---------

Co-authored-by: Farhad Shabani <[email protected]>
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
* fix: restore no_std support for serde feature

* deps: bump ibc-proto-rs to v0.34.0

* fix: reflect changes b/c of ibc-proto-rs

* imp: comply naming + use better domain type for host_consensus_state

* fix: apply host_cons_state_proof changes for conn_open_ack

* fix: use domain TmEvent instead of proto for upgrade client proposal handler

* misc: add a unclog for ibc-proto-rs upgrade
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
… `burn-*` methods (#836)

* split send_coins_*() functions

and introduce extra data

* arg name change

* add error variant

* add error

* add `Other` variant to `TokenTransferError`

* fmt

* fix: restore `no_std` support for `serde` feature (#790)

* fix: restore no_std support for serde feature

* deps: bump ibc-proto-rs to v0.34.0

* fix: reflect changes b/c of ibc-proto-rs

* imp: comply naming + use better domain type for host_consensus_state

* fix: apply host_cons_state_proof changes for conn_open_ack

* fix: use domain TmEvent instead of proto for upgrade client proposal handler

* misc: add a unclog for ibc-proto-rs upgrade

* bump ibc-proto to v0.34.1 and borsh to v0.10 (#844)

* bump ibc-proto and borsh

* changelog

* add borsh derive for `MsgTransfer`

* derive JsonSchema for MsgTransfer

* fix JsonSchema derive for MsgTransfer

Fix is in implementing it properly for our `Timestamp`

* execute() methods must have &mut self

* nit: spell checker

* imp: simplify escrow/unescrow abstraction + using memo instead

* chore: dress up with unclogs

* nit: adjust unlogs

* nit: remove confusing InternalTransferFailed error variant

* imp: add memo field to burn-coins-*

* docs: adjust & add missing docstrings

---------

Co-authored-by: Farhad Shabani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
4 participants