-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to tendermint v0.32, ibc-proto-rs v0.32 #700
Upgrade to tendermint v0.32, ibc-proto-rs v0.32 #700
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
==========================================
+ Coverage 72.28% 72.45% +0.17%
==========================================
Files 117 117
Lines 15526 15514 -12
==========================================
+ Hits 11223 11241 +18
+ Misses 4303 4273 -30
☔ View full report in Codecov by Sentry. |
…rs-0.31 Signed-off-by: Farhad Shabani <[email protected]>
Last thing I'm trying to figure out is:
I couldn't find the PR that removed no-std Serialize, and Deserialize, nor information about it. Do you have more context here?
I don't see any file changed in the CI? |
As of this PR
here we do not enable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Note that I upgraded ibc-proto-rs to v0.32, and documented that the serde
feature no longer works in no_std
(2f4c108)
* Upgrade to tendermint v0.32 and ibc-proto-rs v0.31 * Fix clippy catches * Bump versions in ci/no-std-check * Remove irrelevant docstring * Discard serde & mocks-no-std features from no-std-check * Add unclog * fix: remove ibc-proto features * imp: change ICS* aliases to Raw* for imported specs types * fix: remove cfg-if dependency from cargo.toml * dep: bump ibc-proto-rs to 0.32.0 * fix: revert ibc-proto-rs upgrade * update ibc-proto-rs to v0.32 * document serde feature not working in no_std * fmt --------- Signed-off-by: Farhad Shabani <[email protected]> Co-authored-by: Philippe Laferriere <[email protected]>
Closes: #640
Basecoin update: informalsystems/basecoin-rs#107
Description
Am working on ICS27, needed to upgrade ibc-proto-rs, and respectively tendermint deps. So, come up with this PR ready, though to be merged after
tower-abci
bump tendermint deps to v0.32Note:
Since we removed ics23 from ibc-proto-rs and re-exported the types in v0.31.0, we lost certain attributes like
Eq
, no-stdSerialize
, andDeserialize
on the ics23 proto types. As a result, theserde
feature no longer functions in no-std environments and has been excluded from CI'sno-std-check
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.