Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement upgrade client proposal handler #680

Merged
merged 13 commits into from
May 23, 2023
Merged

Implement upgrade client proposal handler #680

merged 13 commits into from
May 23, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented May 16, 2023 •
edited
Loading

Closes: #141
Closes: #420

See sample implementation for basecoin-rs: informalsystems/basecoin-rs#101

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani mentioned this pull request May 16, 2023
Closed
7 tasks
@codecov
Copy link

codecov bot commented May 16, 2023 •
edited
Loading

Codecov Report

Patch coverage: 5.78% and project coverage change: -1.04 ⚠️

Comparison is base (304cf0e) 73.19% compared to head (85a0b63) 72.16%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
- Coverage   73.19%   72.16%   -1.04%     
==========================================
  Files         113      117       +4     
  Lines       15299    15526     +227     
==========================================
+ Hits        11198    11204       +6     
- Misses       4101     4322     +221
Impacted Files Coverage Δ
crates/ibc/src/applications/transfer/context.rs 51.81% <ø> (ø)
...s/ibc/src/clients/ics07_tendermint/client_state.rs 69.34% <0.00%> (ø)
crates/ibc/src/core/context.rs 63.04% <ø> (ø)
crates/ibc/src/core/handler.rs 88.60% <ø> (ø)
.../src/core/ics04_channel/handler/acknowledgement.rs 94.39% <ø> (ø)
...ates/ibc/src/core/ics04_channel/handler/timeout.rs 95.58% <ø> (ø)
crates/ibc/src/core/msgs.rs 1.05% <ø> (ø)
crates/ibc/src/core/router.rs 81.19% <ø> (ø)
...bc/src/hosts/tendermint/upgrade_proposal/events.rs 0.00% <0.00%> (ø)
...c/src/hosts/tendermint/upgrade_proposal/handler.rs 0.00% <0.00%> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review May 19, 2023 07:20
plafer
plafer reviewed May 22, 2023
View reviewed changes
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

crates/ibc/src/hosts/tendermint/upgrade_proposal/mod.rs Outdated Show resolved Hide resolved
crates/ibc/src/hosts/tendermint/upgrade_proposal/context.rs Show resolved Hide resolved
@plafer
Copy link
Contributor

plafer commented May 23, 2023

Latest changes look good, I'll wait for the basecoin-rs PR to be ready too before we merge this

plafer
plafer approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@plafer plafer merged commit 522aef1 into main May 23, 2023
@plafer plafer deleted the farhad/upgrade-proposal branch May 23, 2023 20:40
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
@Farhad-Shabani @plafer
Implement upgrade client proposal handler (#680)
deac686 
* Abstract upgrade client proposal handler

* Replace all upgrade-related abstractions under tendermint host

* Adjust encapsulation

* Move handler & helper functions to basecoin

* Add unclog

* Refine upgrade client errors

* Reorganize some types

* Add docstring for upgrade client types

* Re-add upgrade_client_proposal_handler

* Make zero_custom_fields public

* upgrade_client_proposal_handler not needed to return Vec<Event>

* upgrade_proposal module dosctring

---------

Co-authored-by: Philippe Laferriere <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plafer plafer plafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
ibc-rs
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a "upgrade client proposal" handler for Tendermint chains Handler for upgrade client
2 participants
@Farhad-Shabani @plafer