Split MsgUpdateClient back into MsgUpdateClient and MsgSubmitMisbehaviour
#643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ff6a968.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
==========================================
- Coverage 73.00% 72.96% -0.04%
==========================================
Files 125 126 +1
Lines 15663 15686 +23
==========================================
+ Hits 11434 11446 +12
- Misses 4229 4240 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Comment on lines
42
to
44
| let domain_msg = | ||
| <update_client::MsgUpdateClient as Protobuf<RawMsgUpdateClient>>::decode_vec( | ||
| &any_msg.value, |
There was a problem hiding this comment.
Can we write update_client::MsgUpdateClient::decode_vec(&any_msg.value) instead?
| update_client::MISBEHAVIOUR_TYPE_URL => { | ||
| let domain_msg = <update_client::MsgUpdateClient as Protobuf< | ||
| misbehaviour::TYPE_URL => { | ||
| let domain_msg = <misbehaviour::MsgSubmitMisbehaviour as Protobuf< | ||
| RawMsgSubmitMisbehaviour, | ||
| >>::decode_vec(&any_msg.value) |
There was a problem hiding this comment.
Same here misbehaviour::MsgSubmitMisbehaviour::decode_vec(&any_msg.value) ?
| @@ -34,8 +19,7 @@ pub enum UpdateKind { | |||
| #[derive(Clone, Debug, PartialEq, Eq)] | |||
| pub struct MsgUpdateClient { | |||
| pub client_id: ClientId, | |||
| pub client_message: Any, | |||
| pub update_kind: UpdateKind, | |||
| pub header: Any, | |||
| pub signer: Signer, | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Should we re-add Msg implementation to be consistent with others?
impl Msg for MsgUpdateClient {
type Raw = RawMsgUpdateClient;
fn type_url(&self) -> String {
TYPE_URL.to_string()
}
}
Farhad-Shabani
approved these changes
Apr 21, 2023
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
…behaviour` (#643) * Add misbehaviour message back * remove Protobuf<Misbehaviour> for UpdateClient message * new `MsgUpdateOrMisbehaviour` * Revert "new `MsgUpdateOrMisbehaviour`" This reverts commit ff6a968. * Fix ClientState::update_state's signature * Update update_client::validate * fix interface * fix TYPE_URL * Move UpdateKind * changelog * fmt * simplify syntax * impl Msg for MsgUpdateClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #628
cc @hdevalence
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.