Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Reader and Keeper API #456

Merged
merged 13 commits into from
Feb 21, 2023
Merged

Remove Reader and Keeper API #456

merged 13 commits into from
Feb 21, 2023

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Feb 21, 2023

Closes: #279

Description

One of my most productive days was throwing away 1,000 lines of code.

- Ken Thompson

@plafer plafer changed the title Remove Reader and Keeper APII Remove Reader and Keeper API Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 60.03% // Head: 69.45% // Increases project coverage by +9.42% 🎉

Coverage data is based on head (db9918e) compared to base (c6b5846).
Patch coverage: 72.22% of modified lines in pull request are covered.

❗ Current head db9918e differs from pull request most recent head 5904117. Consider uploading reports for the commit 5904117 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
+ Coverage   60.03%   69.45%   +9.42%     
==========================================
  Files         131      127       -4     
  Lines       18810    16257    -2553     
==========================================
  Hits        11292    11292              
+ Misses       7518     4965    -2553     
Impacted Files Coverage Δ
crates/ibc/src/core/ics02_client/client_state.rs 75.00% <ø> (ø)
crates/ibc/src/core/ics02_client/handler.rs 0.00% <ø> (ø)
...ibc/src/core/ics02_client/handler/create_client.rs 80.59% <ø> (+30.12%) ⬆️
...bc/src/core/ics02_client/handler/upgrade_client.rs 87.07% <ø> (+27.26%) ⬆️
crates/ibc/src/core/ics03_connection/handler.rs 82.35% <ø> (+35.68%) ⬆️
...src/core/ics03_connection/handler/conn_open_ack.rs 95.78% <ø> (+29.11%) ⬆️
...core/ics03_connection/handler/conn_open_confirm.rs 97.87% <ø> (+27.10%) ⬆️
...rc/core/ics03_connection/handler/conn_open_init.rs 96.19% <ø> (+30.60%) ⬆️
...src/core/ics03_connection/handler/conn_open_try.rs 93.92% <ø> (+29.70%) ⬆️
crates/ibc/src/core/ics04_channel/context.rs 79.62% <ø> (+52.58%) ⬆️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 🙌

Just a few parts are left unused that don't seem to be needed...

crates/ibc/src/core/ics02_client/handler.rs Outdated Show resolved Hide resolved
.changelog/unreleased/improvement/279-remove-legacy-api.md Outdated Show resolved Hide resolved
crates/ibc/src/core/ics03_connection/handler.rs Outdated Show resolved Hide resolved
crates/ibc/src/core/ics04_channel/handler.rs Outdated Show resolved Hide resolved
crates/ibc/src/core/ics02_client/handler/create_client.rs Outdated Show resolved Hide resolved
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@plafer plafer merged commit 45d5f0d into main Feb 21, 2023
@plafer plafer deleted the plafer/279-remove-legacy-api branch February 21, 2023 19:47
@plafer plafer mentioned this pull request Feb 23, 2023
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
* remove dispatch

* ClientState

* ClientState: rename new_*

* Remove Readers and Keepers

* Remove PacketResult struct

* core doc

* changelog

* fmt

* Remove ClientResult

* Remove ConnectionResult

* remove ChannelResult

* changelog breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove legacy Readers and Keepers
2 participants