Prepare to move test code to Validation/ExecutionContext API
#417
Conversation
Codecov ReportBase: 55.93% // Head: 62.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
==========================================
+ Coverage 55.93% 62.21% +6.28%
==========================================
Files 122 131 +9
Lines 17093 17789 +696
==========================================
+ Hits 9561 11068 +1507
+ Misses 7532 6721 -811
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
plafer
changed the title
Validation/ExecutionContext APIValidation/ExecutionContext API
crates/ibc/src/mock/context.rs
Outdated
| @@ -668,6 +679,7 @@ impl RouterBuilder for MockRouterBuilder { | |||
| } | |||
| } | |||
|
|
|||
| // TODO: REMOVE BEFORE MERGING | |||
There was a problem hiding this comment.
any action needed for this comment?
There was a problem hiding this comment.
oops, that will be removed in next PR now. Removed comment: 5c602f1
| /// messages to the correct module handler, and more importantly: (2) the ability of ICS handlers | ||
| /// to work with the context and correctly store results (i.e., the `ClientKeeper`, | ||
| /// `ConnectionKeeper`, and `ChannelKeeper` traits). | ||
| fn routing_module_and_keepers() { |
There was a problem hiding this comment.
Are we gonna also use rstest fixtures here later?
There was a problem hiding this comment.
I think there's a better way to write it using rstest yes; not sure exactly which feature to use. I'll open an issue for it.
* impl ExecutionContext for MockContext * Make MockContext::ValidationContext independent * Change relayer test * re-implement `host_timestamp` in `MockContext` * ics26_routing test changed * fix upgrade_client feature * move ics26_routing dispatch tests * clippy * timeout_on_close rstest for validation * move timeout routing helpers in mod * timeout_on_close_execute test * timeout execute tests * Remove old processing test * fix test * move acknowledgement * move recv_packet * move chan_close_confirm * move chan_close_init * move chan_open_confirm * move chan_open_ack * move chan_open_try * move chan_open_init * remove comment
Work towards: #413
Work towards: #426
Description
timeout_on_closehandler onlyrstestcrateUltimate goal (finished in next PR) is to remove old
Reader/Keepercontext implementations fromMockContext, which requires updating all tests to testvalidate()andexecute()functions as opposed toprocess().PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.