Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove val_exec_ctx feature flag #414

Merged
merged 4 commits into from
Feb 10, 2023
Merged

Remove val_exec_ctx feature flag #414

merged 4 commits into from
Feb 10, 2023

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Feb 10, 2023

Closes: #415

Although the diff is big, all that was done was remove the feature flag.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@plafer plafer changed the title Conver test code to new API Remove val_exec_ctx feature flag Feb 10, 2023
@plafer plafer marked this pull request as ready for review February 10, 2023 15:27
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 55.63% // Head: 55.63% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (388ee98) compared to base (c9c5ee4).
Patch coverage: 5.38% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   55.63%   55.63%   -0.01%     
==========================================
  Files         122      122              
  Lines       17076    16996      -80     
==========================================
- Hits         9501     9455      -46     
+ Misses       7575     7541      -34     
Impacted Files Coverage Δ
crates/ibc/src/applications/transfer/context.rs 35.41% <0.00%> (+0.05%) ⬆️
crates/ibc/src/applications/transfer/relay.rs 0.00% <0.00%> (ø)
.../src/applications/transfer/relay/on_recv_packet.rs 0.00% <0.00%> (ø)
...s/ibc/src/clients/ics07_tendermint/client_state.rs 37.81% <ø> (ø)
crates/ibc/src/core/context.rs 3.88% <ø> (+0.09%) ⬆️
crates/ibc/src/core/ics02_client/client_state.rs 75.00% <ø> (ø)
...ibc/src/core/ics02_client/handler/create_client.rs 35.18% <ø> (ø)
.../ibc/src/core/ics02_client/handler/misbehaviour.rs 53.77% <ø> (ø)
...ibc/src/core/ics02_client/handler/update_client.rs 38.66% <ø> (ø)
...bc/src/core/ics02_client/handler/upgrade_client.rs 64.17% <ø> (ø)
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. thanks

@plafer plafer merged commit 6ad6162 into main Feb 10, 2023
@plafer plafer deleted the plafer/413-test-code-new-API branch February 10, 2023 16:00
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
* remove val_exec_ctx feature

* remove all val_exec_ctx modules

* fmt

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove val_exec_ctx feature flag
2 participants