Fix host_height, host_timestamp return value #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plafer
suggested changes
Nov 18, 2022
| @@ -0,0 +1,2 @@ | |||
| - Change host_height, host_timestamp return value in ics02, ics03, ics04 | |||
There was a problem hiding this comment.
Suggested change
| - Change host_height, host_timestamp return value in ics02, ics03, ics04 | |
| - Change `host_height`, `host_timestamp` return value to a `Result` in `ClientReader`, `ConnectionReader`, and `ChannelReader` |
| @@ -0,0 +1,2 @@ | |||
| - Change host_height, host_timestamp return value in ics02, ics03, ics04 | |||
There was a problem hiding this comment.
Additionally, can we move this to the .changelog/unreleased/breaking-changes directory?
|
Also, now that #241 is merged, could you apply the same change to |
Done |
plafer
reviewed
Nov 21, 2022
|
|
||
| /// Returns the current timestamp of the local chain. | ||
| fn host_timestamp(&self) -> Timestamp { | ||
| fn host_timestamp(&self) -> Result<Timestamp, ClientError> { |
There was a problem hiding this comment.
ClientError is not appropriate here, but we don't have a good solution for that at the moment. We would really need some HostError. We can fix this with #164.
There was a problem hiding this comment.
I would also like to use this way to solve, it is not very clear that the current no_std support is not very perfect
plafer
suggested changes
Nov 21, 2022
plafer
approved these changes
Nov 22, 2022
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Change host_height, host_timestamp return Value * fmt code * Create 242-change-return-value.md * fix clippy * update .changelog * Change host_height, host_timestamp return value in ValidationContext * update Ics18context to RelayerContext in mock/context.rs Signed-off-by: Davirain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #242
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.