Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl: new packet structure for eureka #1365

Open
wants to merge 5 commits into
base: rano/eureka/1367
Choose a base branch
from

Conversation

rnbguy
Copy link
Collaborator

@rnbguy rnbguy commented Oct 23, 2024

Closes: #1364

Description

We use the new v2 packet structure for multi payload structure. The following is the rought overview of the new structure.

Packet {
  header: PacketHeader {
    source_client_on_target: ClientId,
    target_client_on_source: ClientId,
    timeout_on_target: Timeout
    nonce: Bytes,
  },
  payloads: [Payload {
    source_port: PortId.
    target_port: PortId,
    data: Bytes,
  }]
}

Caution

change base branch of PR to feat/ibc-eureka after #1370 is merged


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@rnbguy rnbguy added the O: eureka Objective: implement IBC Eureka label Oct 23, 2024
@rnbguy rnbguy changed the base branch from main to feat/ibc-eureka October 23, 2024 14:57
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 17.34736% with 4007 lines in your changes missing coverage. Please review.

Project coverage is 58.10%. Comparing base (cdd4625) to head (c6d916b).

Files with missing lines Patch % Lines
ibc-eureka-core/ics24-host/types/src/path.rs 0.00% 683 Missing ⚠️
...-eureka-core/ics04-channel/types/src/events/mod.rs 0.00% 591 Missing ⚠️
ibc-eureka-core/ics02-client/types/src/events.rs 52.83% 191 Missing ⚠️
...reka-core/ics04-channel/src/handler/recv_packet.rs 0.00% 174 Missing ⚠️
...c-eureka-core/ics23-commitment/types/src/merkle.rs 0.00% 146 Missing ⚠️
...c-eureka-core/ics04-channel/src/handler/timeout.rs 0.00% 144 Missing ⚠️
ibc-eureka-core/ics04-channel/types/src/packet.rs 0.00% 141 Missing ⚠️
...-core/ics04-channel/src/handler/acknowledgement.rs 0.00% 133 Missing ⚠️
...reka-core/ics04-channel/src/handler/send_packet.rs 0.00% 115 Missing ⚠️
...cs04-channel/types/src/events/packet_attributes.rs 0.00% 88 Missing ⚠️
... and 50 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##           feat/ibc-eureka    #1365      +/-   ##
===================================================
- Coverage            66.84%   58.10%   -8.74%     
===================================================
  Files                  225      287      +62     
  Lines                22631    27479    +4848     
===================================================
+ Hits                 15127    15968     +841     
- Misses                7504    11511    +4007     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnbguy rnbguy force-pushed the rano/eureka/1364 branch 4 times, most recently from c6d916b to 416f410 Compare October 29, 2024 11:01
@rnbguy rnbguy marked this pull request as ready for review October 29, 2024 11:05
@rnbguy rnbguy changed the base branch from feat/ibc-eureka to rano/eureka/1367 October 29, 2024 11:06
@rnbguy rnbguy changed the title feat: eureka packet structure impl: new packet structure for eureka Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: eureka Objective: implement IBC Eureka
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement v2 packet structure
1 participant