Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: remove redundant path constructions in ibc-testkit #1338

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Sep 12, 2024


PR author checklist:

  • Added changelog entry, using unclog.
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.43%. Comparing base (25f730d) to head (a3ab563).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1338      +/-   ##
==========================================
- Coverage   66.46%   66.43%   -0.04%     
==========================================
  Files         227      227              
  Lines       23098    23076      -22     
==========================================
- Hits        15352    15330      -22     
  Misses       7746     7746              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani added this to the 0.55.0 milestone Sep 12, 2024
@seanchen1991 seanchen1991 added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit 8d36c68 Sep 12, 2024
11 checks passed
@seanchen1991 seanchen1991 deleted the farhad/redundant-path-construction branch September 12, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants