Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add SECURITY.md #1328

Merged
merged 6 commits into from
Nov 15, 2024
Merged

chore: add SECURITY.md #1328

merged 6 commits into from
Nov 15, 2024

Conversation

rnbguy
Copy link
Collaborator

@rnbguy rnbguy commented Sep 3, 2024

Closes: #824

Description

Rendered SECURITY.md


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Signed-off-by: Rano | Ranadeep <[email protected]>
@rnbguy rnbguy marked this pull request as draft September 3, 2024 18:08
@rnbguy rnbguy removed the request for review from Farhad-Shabani September 3, 2024 18:08
@seanchen1991
Copy link
Contributor

Just curious if this PR's progress is blocked on anything.

@rnbguy
Copy link
Collaborator Author

rnbguy commented Sep 10, 2024

Hey @seanchen1991, we are waiting to be included in the ICF security program - which is due to happen sometime this month.

Signed-off-by: Rano | Ranadeep <[email protected]>
@rnbguy rnbguy marked this pull request as ready for review September 24, 2024 09:22
Copy link
Member

@greg-szabo greg-szabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed wording in a few places and overhauled the guidelines a bit. Review and ask if you have any questions.

SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
rnbguy and others added 2 commits September 24, 2024 16:11
Co-authored-by: Greg Szabo <[email protected]>
Signed-off-by: Rano | Ranadeep <[email protected]>
Signed-off-by: Rano | Ranadeep <[email protected]>
@rnbguy rnbguy marked this pull request as draft September 24, 2024 15:39
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t have any additional comments. Greg has already gone through it thoroughly. Just as we discussed, please check with Amulet before merging, see if they're good with this SECURITY.md or it would be better we stick to their template, especially since we’re interested in being eventually part of the bounty program.

@rnbguy rnbguy marked this pull request as ready for review November 12, 2024 12:23
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🙏

@rnbguy rnbguy dismissed greg-szabo’s stale review November 15, 2024 11:18

we are using the original SECURITY.md with a mention that IBC is not part of the bounty program

@rnbguy rnbguy added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit b6f4222 Nov 15, 2024
1 check passed
@rnbguy rnbguy deleted the rano/fix-824 branch November 15, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Establish security policy
4 participants