imp(core): remove State::Uninitialized check while parsing ConnectionEnd
#1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1126 +/- ##
==========================================
+ Coverage 66.46% 66.50% +0.04%
==========================================
Files 209 209
Lines 20706 20692 -14
==========================================
Hits 13762 13762
+ Misses 6944 6930 -14 ☔ View full report in Codecov by Sentry. |
.changelog/unreleased/improvements/1123-remove-check-for-unitialized-connection-end-state.md
Outdated
Show resolved
Hide resolved
Farhad-Shabani
approved these changes
Mar 15, 2024
…alized-connection-end-state.md Co-authored-by: Farhad Shabani <[email protected]> Signed-off-by: Rano | Ranadeep <[email protected]>
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
…ionEnd` (#1126) * rm check for uninitialized connection end state * add changelog * Update .changelog/unreleased/improvements/1123-remove-check-for-unitialized-connection-end-state.md Co-authored-by: Farhad Shabani <[email protected]> Signed-off-by: Rano | Ranadeep <[email protected]> * md fmt --------- Signed-off-by: Rano | Ranadeep <[email protected]> Co-authored-by: Farhad Shabani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1123
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.