-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate MsgSubmitMisbehaviour
#1079
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1079 +/- ##
==========================================
- Coverage 66.67% 66.63% -0.05%
==========================================
Files 204 204
Lines 20436 20435 -1
==========================================
- Hits 13626 13617 -9
- Misses 6810 6818 +8 ☔ View full report in Codecov by Sentry. |
MsgSubmitMisbehaviour
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two quick comments and a changelog please. 🙏
* Decorate MsgSubmitMisbehaviour with `deprecated` attribute * Add #[allow(deprecated)] attributes in ibc-testkit * Add #![allow(deprecated)] attribute to ics02/types/msgs/mod.rs * Remove usages of MsgSubmitMisbehaviour from ibc-testkit/update_client.rs * Remove unused rstest fixture * Fix incorrect doc comment * Add changelog entry * chore: add missing unclog for PR835 --------- Co-authored-by: Farhad Shabani <[email protected]>
Closes: #1077
Description
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.