Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate MsgSubmitMisbehaviour #1079

Merged
merged 8 commits into from
Feb 7, 2024

Conversation

seanchen1991
Copy link
Contributor

Closes: #1077

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a275ff) 66.67% compared to head (15372c8) 66.63%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1079      +/-   ##
==========================================
- Coverage   66.67%   66.63%   -0.05%     
==========================================
  Files         204      204              
  Lines       20436    20435       -1     
==========================================
- Hits        13626    13617       -9     
- Misses       6810     6818       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani changed the title Sean/deprecate msg misbehaviour chore: deprecate MsgSubmitMisbehaviour Feb 6, 2024
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two quick comments and a changelog please. 🙏

ibc-core/ics02-client/types/src/msgs/misbehaviour.rs Outdated Show resolved Hide resolved
ibc-testkit/tests/core/ics02_client/update_client.rs Outdated Show resolved Hide resolved
@Farhad-Shabani Farhad-Shabani added this to the 0.51.0 milestone Feb 7, 2024
@Farhad-Shabani Farhad-Shabani merged commit 4428fa9 into main Feb 7, 2024
15 checks passed
@Farhad-Shabani Farhad-Shabani deleted the sean/deprecate-msg-misbehaviour branch February 7, 2024 04:03
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
* Decorate MsgSubmitMisbehaviour with `deprecated` attribute

* Add #[allow(deprecated)] attributes in ibc-testkit

* Add #![allow(deprecated)] attribute to ics02/types/msgs/mod.rs

* Remove usages of MsgSubmitMisbehaviour from ibc-testkit/update_client.rs

* Remove unused rstest fixture

* Fix incorrect doc comment

* Add changelog entry

* chore: add missing unclog for PR835

---------

Co-authored-by: Farhad Shabani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants