Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientState derivation does not work with contexts generic over types and/or lifetimes #910

Closed
Farhad-Shabani opened this issue Oct 10, 2023 · 0 comments · Fixed by #1037
Labels
A: bug Admin: something isn't working
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Farhad-Shabani commented Oct 10, 2023

Summary

From @yito88

The ClientState derivation isn't working well with contexts generic over types/lifetimes.

Details

The following case, for instance, does not work:

#[derive(ClientState)]
#[generics(
    ClientValidationContext = IbcActions::<'_, C>,
    ClientExecutionContext = IbcActions::<'_, C>,
)]
enum AnyClientState {
    Tendermint(TmClientState),
}

As well, this has been experienced in the context of Sovereign SDK integration (see here)

Version

v0.44.1

@Farhad-Shabani Farhad-Shabani added the A: bug Admin: something isn't working label Oct 10, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Oct 10, 2023
mina86 added a commit to ComposableFi/emulated-light-client that referenced this issue Jan 3, 2024
Rather than manually implementing ConsensusState for AnyConsensusState
(which is just boilerplate dispatch code) use a derive to do that for
us.  Unfortunately, we cannot do the same with ClientState because of
<cosmos/ibc-rs#910>.
@Farhad-Shabani Farhad-Shabani added this to the 0.50.0 milestone Jan 12, 2024
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
Status: Done
1 participant