Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ibc-proto to v0.34.1 and borsh to v0.10 #844

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Aug 29, 2023

No description provided.

@plafer plafer marked this pull request as ready for review August 29, 2023 19:20
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01% ⚠️

Comparison is base (d8d4973) 71.48% compared to head (ba36fc9) 71.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #844      +/-   ##
==========================================
- Coverage   71.48%   71.47%   -0.01%     
==========================================
  Files         124      124              
  Lines       14979    14983       +4     
==========================================
+ Hits        10707    10709       +2     
- Misses       4272     4274       +2     
Files Changed Coverage Δ
crates/ibc/src/core/ics03_connection/connection.rs 38.66% <0.00%> (-0.23%) ⬇️
crates/ibc/src/core/timestamp.rs 75.36% <100.00%> (+0.36%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani merged commit 56e7e62 into main Aug 29, 2023
13 checks passed
@Farhad-Shabani Farhad-Shabani deleted the plafer/bump-ibc-proto-34-1 branch August 29, 2023 20:21
plafer added a commit that referenced this pull request Aug 30, 2023
* bump ibc-proto and borsh

* changelog
@Farhad-Shabani Farhad-Shabani added this to the v0.45.0 milestone Sep 7, 2023
Farhad-Shabani added a commit that referenced this pull request Dec 11, 2023
… `burn-*` methods (#836)

* split send_coins_*() functions

and introduce extra data

* arg name change

* add error variant

* add error

* add `Other` variant to `TokenTransferError`

* fmt

* fix: restore `no_std` support for `serde` feature (#790)

* fix: restore no_std support for serde feature

* deps: bump ibc-proto-rs to v0.34.0

* fix: reflect changes b/c of ibc-proto-rs

* imp: comply naming + use better domain type for host_consensus_state

* fix: apply host_cons_state_proof changes for conn_open_ack

* fix: use domain TmEvent instead of proto for upgrade client proposal handler

* misc: add a unclog for ibc-proto-rs upgrade

* bump ibc-proto to v0.34.1 and borsh to v0.10 (#844)

* bump ibc-proto and borsh

* changelog

* add borsh derive for `MsgTransfer`

* derive JsonSchema for MsgTransfer

* fix JsonSchema derive for MsgTransfer

Fix is in implementing it properly for our `Timestamp`

* execute() methods must have &mut self

* nit: spell checker

* imp: simplify escrow/unescrow abstraction + using memo instead

* chore: dress up with unclogs

* nit: adjust unlogs

* nit: remove confusing InternalTransferFailed error variant

* imp: add memo field to burn-coins-*

* docs: adjust & add missing docstrings

---------

Co-authored-by: Farhad Shabani <[email protected]>
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
* bump ibc-proto and borsh

* changelog
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
… `burn-*` methods (#836)

* split send_coins_*() functions

and introduce extra data

* arg name change

* add error variant

* add error

* add `Other` variant to `TokenTransferError`

* fmt

* fix: restore `no_std` support for `serde` feature (#790)

* fix: restore no_std support for serde feature

* deps: bump ibc-proto-rs to v0.34.0

* fix: reflect changes b/c of ibc-proto-rs

* imp: comply naming + use better domain type for host_consensus_state

* fix: apply host_cons_state_proof changes for conn_open_ack

* fix: use domain TmEvent instead of proto for upgrade client proposal handler

* misc: add a unclog for ibc-proto-rs upgrade

* bump ibc-proto to v0.34.1 and borsh to v0.10 (#844)

* bump ibc-proto and borsh

* changelog

* add borsh derive for `MsgTransfer`

* derive JsonSchema for MsgTransfer

* fix JsonSchema derive for MsgTransfer

Fix is in implementing it properly for our `Timestamp`

* execute() methods must have &mut self

* nit: spell checker

* imp: simplify escrow/unescrow abstraction + using memo instead

* chore: dress up with unclogs

* nit: adjust unlogs

* nit: remove confusing InternalTransferFailed error variant

* imp: add memo field to burn-coins-*

* docs: adjust & add missing docstrings

---------

Co-authored-by: Farhad Shabani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants