Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chan_open_{init, try} should not return a ChannelEnd #190

Open
Tracked by #554
plafer opened this issue Oct 21, 2022 · 1 comment
Open
Tracked by #554

chan_open_{init, try} should not return a ChannelEnd #190

plafer opened this issue Oct 21, 2022 · 1 comment
Labels
O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding

Comments

@plafer
Copy link
Contributor

plafer commented Oct 21, 2022

After the core handler runs, we still don't know the version (which will be determined by the callback), so we shouldn't be returning an incomplete ChannelEnd (current workaround is to return an empty version).
@plafer plafer changed the title chan_open_try should not return a ChannelEnd chan_open_{init, try} should not return a ChannelEnd Oct 21, 2022
@plafer plafer added the O: new-feature Objective: aims to add new feature label Nov 14, 2022
@Farhad-Shabani Farhad-Shabani added O: ADR05 O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding and removed O: new-feature Objective: aims to add new feature labels Jan 20, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Feb 2, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Mar 17, 2023
Open
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
@dependabot @crodriguezvega
chore: bump typescript from 4.5.5 to 5.2.2 in /js (cosmos#190)
733ffbf 
* chore: bump typescript from 4.5.5 to 5.2.2 in /js

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.5.5 to 5.2.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.5.5...v5.2.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* bump typescript-eslint dependencies

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Carlos Rodriguez <[email protected]>
@rnbguy
Copy link
Collaborator

rnbguy commented Apr 8, 2024

I think that this can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding
Projects
ibc-rs
Status: 📥 To Do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rnbguy @plafer @Farhad-Shabani