-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timestamp define: not be strongly coupled with the time in tendermint #180
Comments
We previously used the |
Thank you for your explanation, this is just my personal understanding, for the third party light client implementation has Time type in the ConsensusState module, I think the third party light-client implementation should not include the type defined in the tendermint. This is my understanding. |
Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 6.10.3 to 7.2.5. - [Release notes](https://github.com/protobufjs/protobuf.js/releases) - [Changelog](https://github.com/protobufjs/protobuf.js/blob/master/CHANGELOG.md) - [Commits](https://github.com/protobufjs/protobuf.js/commits/protobufjs-v7.2.5) --- updated-dependencies: - dependency-name: protobufjs dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <[email protected]>
So seems fix is cp paste wrapper. And make tendermint into from where needed. Right? It will fix ics20 types tendermint dep removed at least. i am now 816000 bytes, against 819000 contract limit, so i am still ok. |
Summary
Problem Definition
ibc-rs/crates/ibc/src/timestamp.rs
Line 25 in da6653e
Can the definition of
timestamp
here not be strongly coupled with the time intendermint
.Proposal
Acceptance Criteria
For Admin Use
The text was updated successfully, but these errors were encountered: