Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp define: not be strongly coupled with the time in tendermint #180

Closed
5 tasks
DaviRain-Su opened this issue Oct 14, 2022 · 3 comments · Fixed by #1307
Closed
5 tasks

Timestamp define: not be strongly coupled with the time in tendermint #180

DaviRain-Su opened this issue Oct 14, 2022 · 3 comments · Fixed by #1307

Comments

@DaviRain-Su
Copy link
Contributor

Summary

Problem Definition

pub struct Timestamp {

Can the definition of timestamp here not be strongly coupled with the time in tendermint.

Proposal

Acceptance Criteria


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@hu55a1n1
Copy link
Contributor

We previously used the chrono crate but moved away from it (see informalsystems/hermes#1639 and linked issues/PRs for more info). It would be helpful if you could describe your requirements/ideas so we can evaluate potential solutions.

@DaviRain-Su
Copy link
Contributor Author

Thank you for your explanation, this is just my personal understanding, for the third party light client implementation has Time type in the ConsensusState module, I think the third party light-client implementation should not include the type defined in the tendermint. This is my understanding.

shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 6.10.3 to 7.2.5.
- [Release notes](https://github.com/protobufjs/protobuf.js/releases)
- [Changelog](https://github.com/protobufjs/protobuf.js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/protobufjs/protobuf.js/commits/protobufjs-v7.2.5)

---
updated-dependencies:
- dependency-name: protobufjs
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Carlos Rodriguez <[email protected]>
@dzmitry-lahoda
Copy link
Contributor

dzmitry-lahoda commented Dec 5, 2023

So seems fix is cp paste wrapper. And make tendermint into from where needed. Right? It will fix ics20 types tendermint dep removed at least.

i am now 816000 bytes, against 819000 contract limit, so i am still ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants