Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query channel given channel id and port id #130

Closed
ebuchman opened this issue Jul 15, 2020 · 2 comments
Closed

query channel given channel id and port id #130

ebuchman opened this issue Jul 15, 2020 · 2 comments
Assignees
@adizere @greg-szabo

Comments

@ebuchman
Copy link
Member

ebuchman commented Jul 15, 2020 •
edited
Loading

Following the success of informalsystems/hermes#130, we should do the same thing for channels - given a channel id and a port id, fetch the ChannelEnd.

ABCIQuery.Path = store/ibc/key
ABCIQuery.Data = channelEnds/ports/{port identifier}/channels/{channel identifier}

See ICS 24.

Note this query requires both a channel id and port id.
@ancazamfir ancazamfir mentioned this issue Jul 15, 2020
Closed
15 tasks
@adizere
Copy link
Contributor

adizere commented Jul 17, 2020

This issue is (partially?) covered in Greg's PR informalsystems/hermes#152.

@greg-szabo
Copy link
Member

Yes, it's partially covered. As soon as informalsystems/hermes#152 is merged, someone can start working on implementing a decent validation. The validation in informalsystems/hermes#152 is only a "happy path" or "example" (no error handling) so the underlying code can work.

adizere referenced this issue in informalsystems/hermes Jul 21, 2020
@adizere
Validation for channel end + tests template; needs more tests (#148).
8f21ae6
@adizere adizere mentioned this issue Jul 21, 2020
Merged
6 tasks
adizere referenced this issue in informalsystems/hermes Jul 23, 2020
@adizere
Channel query validation & tests & identifier validation fix (#163 #1…
6f89b2d 
…48 #164)

* Refactored the location of JSON files for serialization testing (#118).

* Validation for channel end + tests template; needs more tests (#148).

* Refining tests for channel end.

* Aligned identifier validation with ICS024 & updated tests (#164).

* Added TODO re: version validation; fix VALID_SPECIAL_CHARS to remove space.

* Fixing the TODO for version field validation.
romac referenced this issue in informalsystems/hermes Jul 29, 2020
@adizere @romac
Channel query validation & tests & identifier validation fix (#163 #1…
a24b416 
…48 #164)

* Refactored the location of JSON files for serialization testing (#118).

* Validation for channel end + tests template; needs more tests (#148).

* Refining tests for channel end.

* Aligned identifier validation with ICS024 & updated tests (#164).

* Added TODO re: version validation; fix VALID_SPECIAL_CHARS to remove space.

* Fixing the TODO for version field validation.
@greg-szabo greg-szabo mentioned this issue Jul 30, 2020
Merged
6 tasks
hu55a1n1 referenced this issue in hu55a1n1/hermes Sep 13, 2022
@adizere
Channel query validation & tests & identifier validation fix (informa…
40486fe 
…lsystems#163 #148 #164)

* Refactored the location of JSON files for serialization testing (#118).

* Validation for channel end + tests template; needs more tests (#148).

* Refining tests for channel end.

* Aligned identifier validation with ICS024 & updated tests (#164).

* Added TODO re: version validation; fix VALID_SPECIAL_CHARS to remove space.

* Fixing the TODO for version field validation.
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
hu55a1n1 pushed a commit that referenced this issue Sep 29, 2022
@adizere @andynog
Connection queries for Relayer (#136)
4c5754c 
* Initial implementation of proto files required for connection. Proto files generated but replacing connection mod breaks the build

* Removed reference to MerklePrefix

* Implemented logic to proto_unmarshall the connection using prost #130

* Trimmed the proto file, fixed commitments. Ready for review. (#130)

* Fixed a couple of nits

* Fix for unused_qualifications h/t @gregszabo @andynog.

* Fixing unit testing since CommitPrefix was changed, failed to cargo build #136

* Replaced prost compilation with dependency on ibc-proto crate.

* Better error propagation in connection query.

* Fixed error handling when specifying height (-h) parameter in a query connection. Doesn't throw exception anymore. Show error message. #130

* Added validation for versions in ConnectionEnd unmarshalling

* Implemented fmt::Debug trait for CommitPrefix to properly display its value (string instead of vector of bytes). Assumes value is valid utf-8. #136

Co-authored-by: Andy Nogueira <[email protected]>
livelybug pushed a commit to octopus-network/ibc-rs that referenced this issue Oct 14, 2022
@adizere @andynog
Connection queries for Relayer (cosmos#136)
fa4cf48 
* Initial implementation of proto files required for connection. Proto files generated but replacing connection mod breaks the build

* Removed reference to MerklePrefix

* Implemented logic to proto_unmarshall the connection using prost cosmos#130

* Trimmed the proto file, fixed commitments. Ready for review. (cosmos#130)

* Fixed a couple of nits

* Fix for unused_qualifications h/t @gregszabo @andynog.

* Fixing unit testing since CommitPrefix was changed, failed to cargo build cosmos#136

* Replaced prost compilation with dependency on ibc-proto crate.

* Better error propagation in connection query.

* Fixed error handling when specifying height (-h) parameter in a query connection. Doesn't throw exception anymore. Show error message. cosmos#130

* Added validation for versions in ConnectionEnd unmarshalling

* Implemented fmt::Debug trait for CommitPrefix to properly display its value (string instead of vector of bytes). Assumes value is valid utf-8. cosmos#136

Co-authored-by: Andy Nogueira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adizere adizere

@greg-szabo greg-szabo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adizere @ebuchman @greg-szabo