Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gomod changes and minor updates #7549

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Gomod changes and minor updates #7549

merged 5 commits into from
Nov 11, 2024

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 11, 2024

Description

Dependencies and minor updates

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@tac0turtle tac0turtle merged commit e06d2c5 into cosmos:marko/gomod_change Nov 11, 2024
6 of 25 checks passed
damiannolan
damiannolan reviewed Nov 19, 2024
View reviewed changes
modules/apps/27-interchain-accounts/module.go
@@ -35,7 +35,6 @@ var (
_ module.AppModuleSimulation = (*AppModule)(nil)
_ module.HasGenesis = (*AppModule)(nil)
_ module.HasServices = (*AppModule)(nil)
_ module.HasProposalMsgs = (*AppModule)(nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the impl of ProposalMsgs be removed along with this?

@alpe alpe deleted the alex/marko/gomod_change branch November 27, 2024 10:43
github-merge-queue bot pushed a commit that referenced this pull request Dec 17, 2024
@tac0turtle @alpe
@chatton @damiannolan @bznein @DimitrisJim
deps: update to cosmos-sdk v0.52 (Olympus) (#7261)
8575743 
* go mod changes

* remove cometabci direct dep

* fix all errors

* appmodule & simapp cleanup

* 08wasm fixes

* get 08-wasm compiling

* another simapp

* another simapp

* pass in environment

* fix compilation errors

* some fixes

* build

* fix other simapps

* linting

* remove unsed code

* go mod changes

* add pool module

* anothersimapp

* linting fixes

* protocol pool module accounts

* callback fixes

* simapp fixes

* register interfaces

* fix feeibc

* changes++

* fix missed conflict

* fix wasm client

* linting fixes

* fix tests

* linting

* fix simapp tests

* fix some tests

* fix e2e go mod

* go mod changes

* remove grandpa

* Gomod changes and minor updates (#7549)

* Remove module.HasProposalMsgs

* Update ante handler

* Bump versions

* x

* Cleanup

* chore: use same tags for all go mods

* chore: update go mod files, revert callbacks simapp changes

* chore: fix tendermint client test suite

* chore: fix tests in TestAnteDecoratorCheckTx

* chore: fix event tests

* chore: fix compiler error in simapp

* deps: update to latest of cosmossdk.io/store main to fix proofs test

* chore: tidy all

* fix: remove ibcmock module acc from blocked addrs

* chore: fix proto failures and Gov errors

* chore: fix ica test

* chore: fix a few compiler errs in 08-wasm

* fix: update ica account already exists test to front run account creation correctly

* chore: fix ica test for address gen

* chore: re-add log to returned error

* chore: update go mods

* chore: fixed build errors in wasm app.go

* chore: cleanup callbacks simapp

* chore: fixing simulation functions

* chore: reconfigure simd cmd and fix TestInitCmd

* feat: add runtime Env to icacontroller and fix v0.52 e2e tests (#7587)

* feat: adding runtime Environment

* chore: run make lint-fix

* chore: remove duplicate import

* chore: rm duplicate import

* chore: migrate to env KVStoreService in icacontroller

* chore: fix duplicate import

* chore: rm kv store service

* chore: refactor events to use environment

* chore: make lint-fix

* chore: make tidy-all

* chore: rm msg service router from icacontroller

* fix: remove 32 bit arm arch from callbacks ci builds

* test: try cache false for callbacks linter

* chore: pin to updated interchaintest fork

* chore: revert relayer count to 10

* chore: continued work on upgrading e2e tests to 0.52

* chore: transfer e2e passing

* chore: fix upgrade build errors

* chore: bump interchaintest

* chore: update  sample config

* chore: reconfigure protoany to use gogoproto any in favour of codec types

* chore: tidy imports in e2e

* fix: address failure in module safe query ica e2e test

* bump golangci version to 1.60

* lint: remove duplicate import

* chore: use gogoprotoany in favour of codec types any. rm ProtoCodecMarshaler for Codec iface

* chore: bump go version in Dockerfile

* chore: add todo

* lint: fix unnecessary cast

* deps: upgrade sdk to head of release/v0.52.x, upgrade store to latest main

* deps: bump to head of release/v0.52

* fix: add unit test to reproduce e2e test failure for ScheduleIBCUpgrade, update code to expect tendermint client temporarily

* fix: error in tests

* chore: address comments from pr

---------

Co-authored-by: chatton <[email protected]>
Co-authored-by: Nikolas De Giorgis <[email protected]>

* chore: linter fixes

* lint: ignore redunant import alias

* chore: rm redudant semi-colon in tendermint.proto

* chore: rm redundant doc string regarding e2e-compatibility tests - tests now use annoations for compatibility checks

* chore: update dead links

* fix: apply fix for x/tx cosmos-sdk #22574

* chore: make lint-fix

* fix: use hermes v1.10.4 for ci configs

* fix: apply fix for cosmos-sdk #22779 and update dependencies

* fix: unpin local sdk to HEAD of release/v0.52 in simapp go.mod

* chore: revert docs/versioned_docs to main

* chore: ammendments to linter configs

* chore: update var name in expected keeper

* chore: revert diffs in clienttypes/height_test

* chore: propagate error from event emission in icacontroller

* test: revert unnecessary diffs in test fn

* chore: update comment in test chain

* Update e2e/tests/interchain_accounts/base_test.go

Co-authored-by: DimitrisJim <[email protected]>

* chore: nit on import aliasing

* refactor: rename instances of expected keepers from accountKeeper -> authKeeper where apt

* chore: readd TestABCICodeDeterminism to 04-channel types

* refactor: remove redundant AppModuleBasics

* chore: rm GetStakingKeeper api from testing app

* chore: update version in wasm dockerfile

* chore: update the go work example file version

* chore: rm UnwrapSDKContext in ica where possible

* fix: import path in e2e from suggestion

---------

Co-authored-by: Alexander Peters <[email protected]>
Co-authored-by: chatton <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
Co-authored-by: Nikolas De Giorgis <[email protected]>
Co-authored-by: DimitrisJim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damiannolan damiannolan damiannolan left review comments

@tac0turtle tac0turtle tac0turtle approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

@srdtrk srdtrk Awaiting requested review from srdtrk

@chatton chatton Awaiting requested review from chatton

@DimitrisJim DimitrisJim Awaiting requested review from DimitrisJim

@gjermundgaraba gjermundgaraba Awaiting requested review from gjermundgaraba

@bznein bznein Awaiting requested review from bznein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alpe @damiannolan @tac0turtle