Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove mock from top level simapp app.go #7444

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

colin-axner
Copy link
Contributor

Description

I was going through old issues and thought I'd take care of this one real quick

closes: #7066


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link

sonarcloud bot commented Oct 15, 2024

@colin-axner colin-axner added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit f59dbcc Oct 15, 2024
69 of 70 checks passed
@colin-axner colin-axner deleted the colin/7066-remove-mock-module branch October 15, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mock modules from simapp binary app.go
3 participants