Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update migration docs for merkle path v2 changes #6757
docs: update migration docs for merkle path v2 changes #6757
Changes from 4 commits
da18493
0b303a6
d10d30d
b044e9d
0d2fd64
44dafca
31b65c8
23edc41
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srdtrk, could you confirm if this is correct unmarshalling syntax for
[]string
->[][]byte
? I can also modify the composable-ibc grandpa-cw contract and try to test thisthis was based on code here: https://github.com/ComposableFi/composable-ibc/blob/main/light-clients/ics10-grandpa-cw/src/msg.rs#L150-L167
I'm unsure if
Bytes
is some kind of alias or not. IsVec<Vec<u8>>
valid syntax also? Maybe with the alias is fine...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wouldn't work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the right way to do it, @srdtrk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've decided to replace the usage of Bytes with
cosmwasm_std::Binary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.rs/cosmwasm-std/2.0.4/cosmwasm_std/struct.Binary.html