Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document limits in string fields #6671

Merged

Conversation

crodriguezvega
Copy link
Contributor

@crodriguezvega crodriguezvega commented Jun 21, 2024

Description

I will also update v7.6.x docs when #6670 is merged.

closes: #6666


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@crodriguezvega crodriguezvega linked an issue Jun 21, 2024 that may be closed by this pull request
@crodriguezvega crodriguezvega added the priority PRs that need prompt reviews label Jun 26, 2024
@crodriguezvega crodriguezvega marked this pull request as ready for review June 26, 2024 19:49
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr for issue 6666 is fire though 😄 we should also make sure to mention destinationMemo after forwarding. I leave it up to you to add here after the feature branch is merged to main or as a separate PR.

@crodriguezvega
Copy link
Contributor Author

pr for issue 6666 is fire though 😄 we should also make sure to mention destinationMemo after forwarding. I leave it up to you to add here after the feature branch is merged to main or as a separate PR.

I think I prefer to add this one as part of #6608. I will add your comment to the issue so that we don't forget about it.

@crodriguezvega crodriguezvega added this pull request to the merge queue Jun 27, 2024
Merged via the queue into main with commit c44315b Jun 27, 2024
26 checks passed
@crodriguezvega crodriguezvega deleted the carlos/6666-docs-add-information-about-field-size-limits branch June 27, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PRs that need prompt reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add information about field size limits
3 participants