08-wasm: rename client store

[crodriguezvega]

Description

I was happy enough with Damian's suggestion.

closes: #6182

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against the correct branch (see CONTRIBUTING.md).
• Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
• Code follows the module structure standards and Go style guide.
• Wrote unit and integration tests.
• Updated relevant documentation (docs/).
• Added relevant godoc comments.
• Provide a conventional commit message to follow the repository standards.
• Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
• Re-reviewed Files changed in the GitHub PR explorer.
• Review SonarCloud Report in the comment section below once CI passes.

Summary by CodeRabbit

• Refactor
  • Enhanced naming convention by renaming struct for improved clarity and consistency.
  • Updated function and method names for better readability and maintainability.
  • Adjusted tests to align with the renamed struct.
  • Updated function to validate client state using the new struct name.
  • Replaced function call for consistency.

[coderabbitai]

Walkthrough

The recent updates involve renaming the MergedClientStore to ClientRecoveryStore in the 08-wasm module, affecting various files including type definitions and function calls. This change aligns with the decision to finalize the naming convention for the client store used during migration processes in the module.

Changes

File Path	Change Summary
modules/light-clients/08-wasm/internal/types/store.go, modules/light-clients/08-wasm/internal/types/store_test.go	Renamed MergedClientStore to ClientRecoveryStore; updated related functions and test methods.
modules/light-clients/08-wasm/keeper/contract_keeper.go	Updated function to check for ClientRecoveryStore instead of MergedClientStore.
modules/light-clients/08-wasm/light_client_module.go	Replaced NewMergedClientStore function call with NewClientRecoveryStore.

Assessment against linked issues

Objective	Addressed	Explanation
Decide on naming of client store used in 08-wasm migration (#6182)	✅
Identify issues with existing 08-wasm module handling light clients for multiple chains (#5084)	❌	The changes focus solely on renaming and do not address module functionality.
Enhance the flexibility, maintainability, and efficiency of the 08-wasm module (#5084)	❌	The changes are limited to renaming and do not involve structural enhancements.

Possibly related issues

• Issue Restructure 02-client to a more generalized light client handler #5084: This issue discusses enhancing the 08-wasm module's flexibility and maintainability. The current PR could be a precursor to more extensive changes aimed at addressing these broader objectives.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[damiannolan]

Left one suggestion on receiver args! LGTM

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Fix typographical error in the comment.

- // NewClientRecoveryStore retusn a new instance of a ClientRecoveryStore
+ // NewClientRecoveryStore returns a new instance of a ClientRecoveryStore

---

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	// NewClientRecoveryStore returns a new instance of a ClientRecoveryStore
	func NewClientRecoveryStore(subjectStore, substituteStore storetypes.KVStore) ClientRecoveryStore {
	// NewClientRecoveryStore returns a new instance of a ClientRecoveryStore
	func NewClientRecoveryStore(subjectStore, substituteStore storetypes.KVStore) ClientRecoveryStore {

[DimitrisJim]

perfectly happy with this too!

[sonarqubecloud]

Quality Gate passed for 'ibc-go'

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud