imp: separate height and timestamp attribute in upgrade timeout event #5612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
crodriguezvega
added
channel-upgradability
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5612 +/- ##
=======================================
Coverage 81.18% 81.19%
=======================================
Files 197 197
Lines 15247 15258 +11
=======================================
+ Hits 12378 12388 +10
- Misses 2404 2405 +1
Partials 465 465
|
chatton
approved these changes
Jan 16, 2024
crodriguezvega
deleted the
carlos/separate-height-timestamp-attribute-upgrade-timeout-event
branch
crodriguezvega
added a commit
that referenced
this pull request
Jan 16, 2024
…#5612) (#5614) (cherry picked from commit d596310) Co-authored-by: Carlos Rodriguez <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After merged I will probably rename the attributes in #5603.
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.