Add missing channel upgrade tests #5502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5502 +/- ##
==========================================
+ Coverage 80.96% 81.06% +0.10%
==========================================
Files 197 197
Lines 15221 15221
==========================================
+ Hits 12323 12339 +16
+ Misses 2427 2413 -14
+ Partials 471 469 -2
|
AdityaSripal
approved these changes
Jan 2, 2024
DimitrisJim
reviewed
Jan 2, 2024
| tc := tc | ||
| suite.Run(tc.name, func() { | ||
| suite.SetupTest() | ||
| _, err := keeper.Keeper.UpdateChannelParams(*suite.chainA.App.GetIBCKeeper(), suite.chainA.GetContext(), tc.msg) |
There was a problem hiding this comment.
want to also add a check for nil/non-nil assert on the resp?
| @@ -27,10 +28,10 @@ func DefaultParams() Params { | |||
| // Validate the params. | |||
| func (p Params) Validate() error { | |||
| if !p.UpgradeTimeout.Height.IsZero() { | |||
| return fmt.Errorf("upgrade timeout height must be zero. got : %v", p.UpgradeTimeout.Height) | |||
| return errorsmod.Wrapf(ErrInvalidTimeout, "upgrade timeout height must be zero. got : %v", p.UpgradeTimeout.Height) | |||
There was a problem hiding this comment.
this seems to be 'invalid packet timeout' yea? Do we want separate error? I'm actually not finding other references for that error tbh 🤔
edit: we could just tweak err message?
There was a problem hiding this comment.
good call, it looks like we already have a ErrInvalidUpgradeTimeout, we can use that instead!
crodriguezvega
added
channel-upgradability
9 tasks
crodriguezvega
approved these changes
Jan 4, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
(cherry picked from commit b2368fa) # Conflicts: # modules/core/04-channel/types/msgs.go # modules/core/keeper/msg_server_test.go
crodriguezvega
added a commit
that referenced
this pull request
Jan 5, 2024
* Add missing channel upgrade tests (#5502) (cherry picked from commit b2368fa) # Conflicts: # modules/core/04-channel/types/msgs.go # modules/core/keeper/msg_server_test.go * fix conflicts --------- Co-authored-by: Cian Hatton <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #5485
Add missing tests for channel upgrades
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.