Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CommitHeader to TestChain struct #5435

Merged
merged 9 commits into from
Jan 24, 2024

Conversation

phamminh0811
Copy link
Contributor

@phamminh0811 phamminh0811 commented Dec 18, 2023

Description

Closes #3972

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@crodriguezvega crodriguezvega added the priority PRs that need prompt reviews label Jan 15, 2024
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phamminh0811! I pushed some minor improvements. LGTM

@colin-axner colin-axner added the testing Testing package and unit/integration tests label Jan 24, 2024
testing/chain.go Outdated Show resolved Hide resolved
@damiannolan damiannolan enabled auto-merge (squash) January 24, 2024 13:51
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@damiannolan damiannolan merged commit 2f3fa4b into cosmos:main Jan 24, 2024
61 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PRs that need prompt reviews testing Testing package and unit/integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CommitHeader to the TestChain struct
6 participants