Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fmt.sprint() usage #5403

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

chandiniv1
Copy link
Contributor

closes: #2265

@DimitrisJim DimitrisJim changed the title remove fmt.sprint() usuage Remove fmt.sprint() usage Dec 20, 2023
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly agree with Carlos's comment in parent issue but ok with pushing it in since pr was opened!

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (335e4ff) 80.10% compared to head (9aef18b) 80.10%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5403   +/-   ##
=======================================
  Coverage   80.10%   80.10%           
=======================================
  Files         189      189           
  Lines       13146    13147    +1     
=======================================
+ Hits        10531    10532    +1     
  Misses       2202     2202           
  Partials      413      413           
Files Coverage Δ
modules/apps/27-interchain-accounts/types/port.go 100.00% <100.00%> (ø)

@crodriguezvega crodriguezvega merged commit cea0a82 into cosmos:main Dec 20, 2023
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants