Implement OnChanUpgradeTry on Host Chain for interchain-accounts #5144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainaccounts' into cian/issue#5142-implement-onchanupgradetry-on-host-chain-for-interchainaccounts
…ainaccounts' into cian/issue#5142-implement-onchanupgradetry-on-host-chain-for-interchainaccounts
There was a problem hiding this comment.
I know this is still in draft, but I left just a few comments.
Same as my comment in #5141: I think we should also implement OnChanUpgradeTry in the controller submodule and return an error saying that the upgrade handshake must be initiated by the controller chain.
modules/apps/27-interchain-accounts/controller/keeper/handshake_test.go
Outdated
Show resolved
Hide resolved
modules/apps/27-interchain-accounts/controller/keeper/handshake_test.go
Outdated
Show resolved
Hide resolved
…hanupgradetry-on-host-chain-for-interchainaccounts
charleenfei
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
…hanupgradetry-on-host-chain-for-interchainaccounts
crodriguezvega
approved these changes
Dec 10, 2023
…hanupgradetry-on-host-chain-for-interchainaccounts
charleenfei
deleted the
cian/issue#5142-implement-onchanupgradetry-on-host-chain-for-interchainaccounts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Review after #5141
closes: #5142
ref: the spec
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.