-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: implement codec registration tests for ibc core and lightclients #4757
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4757 +/- ##
==========================================
+ Coverage 79.49% 79.75% +0.25%
==========================================
Files 189 189
Lines 13285 13285
==========================================
+ Hits 10561 10595 +34
+ Misses 2296 2262 -34
Partials 428 428 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I wonder if there are some duplicate tests that can be removed now. Curious if this covers testing for UnpackInterfaces func needing to be required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice 🥳
Indirectly I think it kind of covers it. But its not really explicit. I think its probably worth keeping the existing marshal/unmarshal tests for |
Description
ref: #4747
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.