Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: implement codec registration tests for ibc core and lightclients #4757

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

damiannolan
Copy link
Member

Description

ref: #4747


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@damiannolan damiannolan added the testing Testing package and unit/integration tests label Sep 25, 2023
@damiannolan damiannolan marked this pull request as ready for review September 25, 2023 09:54
@codecov-commenter
Copy link

Codecov Report

Merging #4757 (295c2ca) into main (e443a88) will increase coverage by 0.25%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4757      +/-   ##
==========================================
+ Coverage   79.49%   79.75%   +0.25%     
==========================================
  Files         189      189              
  Lines       13285    13285              
==========================================
+ Hits        10561    10595      +34     
+ Misses       2296     2262      -34     
  Partials      428      428              

see 1 file with indirect coverage changes

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I wonder if there are some duplicate tests that can be removed now. Curious if this covers testing for UnpackInterfaces func needing to be required

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice 🥳

@damiannolan
Copy link
Member Author

Nice! I wonder if there are some duplicate tests that can be removed now. Curious if this covers testing for UnpackInterfaces func needing to be required

Indirectly I think it kind of covers it. But its not really explicit. I think its probably worth keeping the existing marshal/unmarshal tests for Any unpacking for now until it can be further worked out.

@damiannolan damiannolan enabled auto-merge (squash) September 25, 2023 11:50
@damiannolan damiannolan merged commit 2bdb699 into main Sep 25, 2023
25 of 26 checks passed
@damiannolan damiannolan deleted the damian/4747-codec-registration-tests branch September 25, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing package and unit/integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants