e2e: conditionally querying total escrow based on release version #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal,
charleenfei,
damiannolan,
chatton and
DimitrisJim
as code owners
crodriguezvega
commented
May 25, 2023
| @@ -64,13 +63,6 @@ const ( | |||
| icadBinary = "icad" | |||
| ) | |||
|
|
|||
| // icadNewGenesisCommandsFeatureReleases represents the releases of icad using the new genesis commands. | |||
There was a problem hiding this comment.
I moved this already in this PR to testvalues.
chatton
approved these changes
May 25, 2023
| @@ -402,8 +394,8 @@ func getGenesisModificationFunction(cc ChainConfig) func(ibc.ChainConfig, []byte | |||
| binary := cc.Binary | |||
| version := cc.Tag | |||
|
|
|||
| doesSimdSupportGovv1Genesis := binary == defaultBinary && govGenesisFeatureReleases.IsSupported(version) | |||
| doesIcadSupportGovv1Genesis := icadGovGenesisFeatureReleases.IsSupported(version) | |||
| doesSimdSupportGovv1Genesis := binary == defaultBinary && testvalues.GovGenesisFeatureReleases.IsSupported(version) | |||
There was a problem hiding this comment.
mega nit, I find using does in the name is confusing, to me it is more readable with a name like simdSupportsGovV1Genesis (statement rather than question)
I know this wasn't introduced in this PR so I don't feel too strongly about it.
| actualTotalEscrow, err := s.QueryTotalEscrowForDenom(ctx, chainA, chainADenom) | ||
| s.Require().NoError(err) | ||
| s.Require().Equal(sdk.NewCoin(chainADenom, sdk.NewInt(0)), actualTotalEscrow) // total escrow is zero because tokens have come back | ||
| if testvalues.TotalEscrowFeatureReleases.IsSupported(chainAVersion) { |
There was a problem hiding this comment.
should the t.Run be put within the conditional? As it currently is this will be an empty test
crodriguezvega
deleted the
carlos/conditionally-query-total-escrow-based-on-release-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.