Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transfer): change Authorization interface implementation in proto file #3596

Merged

Conversation

Vvaradinov
Copy link
Contributor

Description

Hi team, I noticed a suspicious error when testing out our Evmos local node with the recent backported changes in v6.2.

Error: unable to create codec descriptor: unable to get proto name for implementing type / for interface cosmos.v1beta1.Authorization

I've located a typo in the TransferAuthorization proto message using the wrong interface name for Authorization. After changing it the error goes away and the local node is started correctly.

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that this is a requirement on sdk v0.46. We had an issue #2977 opened to correctly use the fully qualified proto type URL for these interfaces.


I decided to check: its because the v0.46 code does not register the interface as cosmos.authz.v1beta1.Authorization but cosmos.v1beta1.Authorization lol

@colin-axner
Copy link
Contributor

Interesting that this is a requirement on sdk v0.46. We had an issue #2977 opened to correctly use the fully qualified proto type URL for these interfaces.

I decided to check: its because the v0.46 code does not register the interface as cosmos.authz.v1beta1.Authorization but cosmos.v1beta1.Authorization lol

Does cosmos.v1beta1.Authorization work? Or was #2977 only in reference to v0.47+?

@crodriguezvega
Copy link
Contributor

Are we happy using Authorization or should we use cosmos.v1beta1.Authorization?

@damiannolan
Copy link
Member

Are we happy using Authorization or should we use cosmos.v1beta1.Authorization?

I think either is fine. IIRC correctly the fully qualified name isn't a requirement until > sdk 0.47

@crodriguezvega crodriguezvega merged commit ac1df67 into cosmos:release/v6.2.x May 24, 2023
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants