transfer (total escrow): add escrow / unescrow functions #3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 22, 2023 23:38
crodriguezvega
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
7 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3507 +/- ##
==========================================
- Coverage 78.78% 78.77% -0.01%
==========================================
Files 182 182
Lines 12687 12686 -1
==========================================
- Hits 9995 9994 -1
Misses 2261 2261
Partials 431 431
|
crodriguezvega
changed the title
colin-axner
approved these changes
Apr 27, 2023
DimitrisJim
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
should these target the feat/total-escrow-state-entry branch?
damiannolan
approved these changes
May 2, 2023
Comment on lines
372
to
374
| if err := k.bankKeeper.SendCoins( | ||
| ctx, sender, escrowAddress, sdk.NewCoins(token), | ||
| ); err != nil { |
There was a problem hiding this comment.
nit; I think we should put this on one line similarly to below in unescrowToken
There was a problem hiding this comment.
I thought about the same, agreed! I think it helps to make the functions as identical as possible
No, since this is just code-hygenie/readability, I think it makes sense not to backport |
mergify bot
pushed a commit
that referenced
this pull request
May 3, 2023
* add escrow/unescrow functions * fix * fix linter warning * imp. add more code documentation * chore. restructure code to match sybling function --------- Co-authored-by: Colin Axnér <[email protected]> Co-authored-by: Jim Fasarakis-Hilliard <[email protected]> (cherry picked from commit 9ebc2f8) # Conflicts: # modules/apps/transfer/keeper/relay.go
damiannolan
added a commit
that referenced
this pull request
May 4, 2023
) (#3550) * transfer (total escrow): add escrow / unescrow functions (#3507) * add escrow/unescrow functions * fix * fix linter warning * imp. add more code documentation * chore. restructure code to match sybling function --------- Co-authored-by: Colin Axnér <[email protected]> Co-authored-by: Jim Fasarakis-Hilliard <[email protected]> (cherry picked from commit 9ebc2f8) # Conflicts: # modules/apps/transfer/keeper/relay.go * resolving conflicts --------- Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Damian Nolan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #3368
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.