Add upgrade type verification function #3453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-upgrade-type-and-validate-basic-functions
…e-basic-functions' into cian/issue#3451-add-verifiable-upgrade-type-and-validate-basic-functions
damiannolan
approved these changes
Apr 13, 2023
crodriguezvega
approved these changes
Apr 14, 2023
There was a problem hiding this comment.
Thank you, @chatton. Can we then remove VerifyChannelUpgradeTimeout and VerifyChannelUpgradeSequence` functions?
| expPass: false, | ||
| }, | ||
| { | ||
| name: "fails with bad client id", |
There was a problem hiding this comment.
Suggested change
| name: "fails with bad client id", | |
| name: "fails with invalid client id", |
There was a problem hiding this comment.
we bave "bad client id" for all other tests doing this check, if we want to change it we should probably do it everywhere (I think not in this PR though!)
| ) | ||
|
|
||
| // NewUpgrade creates a new Upgrade instance. | ||
| func NewUpgrade(modifiableFields ModifiableUpgradeFields, timeout UpgradeTimeout, lastPacketSent uint64) *Upgrade { |
There was a problem hiding this comment.
Suggested change
| func NewUpgrade(modifiableFields ModifiableUpgradeFields, timeout UpgradeTimeout, lastPacketSent uint64) *Upgrade { | |
| func NewUpgrade(upgradeFields UpgradeFields, timeout UpgradeTimeout, lastPacketSent uint64) *Upgrade { |
| expPass: false, | ||
| }, | ||
| { | ||
| name: "verification fails when the ordering is different", |
There was a problem hiding this comment.
Suggested change
| name: "verification fails when the ordering is different", | |
| name: "fails when the upgrade field is different", |
| upgrade = channeltypes.NewUpgrade( | ||
| channeltypes.NewModifiableUpgradeFields(channeltypes.UNORDERED, []string{path.EndpointA.ConnectionID}, "v1.0.0"), | ||
| channeltypes.NewUpgradeTimeout(clienttypes.ZeroHeight(), 100000), | ||
| 0, |
There was a problem hiding this comment.
Suggested change
| 0, | |
| 1, |
There was a problem hiding this comment.
should last packet sent be 1 if we have not sent any packets?
…e-basic-functions' into cian/issue#3451-add-verifiable-upgrade-type-and-validate-basic-functions
Base automatically changed from
cian/issue#3445-add-verifiable-upgrade-type-and-validate-basic-functions
to
04-channel-upgrades
April 18, 2023 08:35
chatton
commented
Apr 18, 2023
| @@ -364,16 +364,15 @@ func (k Keeper) VerifyNextSequenceRecv( | |||
| return nil | |||
There was a problem hiding this comment.
the diff in this file is quite confusing, the following functions were removed
VerifyChannelUpgradeSequenceVerifyChannelUpgradeTimeout
damiannolan
approved these changes
Apr 18, 2023
Comment on lines
21
to
22
| // NewModifiableUpgradeFields returns a new ModifiableUpgradeFields instance. | ||
| func NewModifiableUpgradeFields(ordering Order, connectionHops []string, version string) UpgradeFields { |
There was a problem hiding this comment.
nit: remove "Modifiable" here I guess?
chatton
deleted the
cian/issue#3451-add-verifiable-upgrade-type-and-validate-basic-functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #3446
Commit Message / Changelog Entry
N/A feature branch
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.