-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support configuration file for e2e tests #3260
Merged
chatton
merged 38 commits into
main
from
cian/issue#3254-add-support-for-config-file-for-running-e2e-tests
Mar 21, 2023
Merged
Changes from 25 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
e8e5760
support configuration file for e2e tests
chatton 0d6ad85
return chain a tag if b tag is not specified
chatton 1506784
apply env var overrides correctly
chatton cb5453b
correctly specify chain IDs
chatton 2da60ba
chore: change tendermint logging to debug for e2e
colin-axner f8d3fd5
fix: correctly set override
colin-axner ffd1bc6
Merge branch 'main' into colin/e2e-logging
chatton 5d981e8
adding script to init the config file
chatton 0430410
cleaning up test config merging and fixing init script
chatton b6d433d
added upgrade configs to sample config
chatton 3d64b25
remove upgrade plans
chatton 5854ee1
added explicit environmental variable name requirement
chatton 58994aa
merge main
chatton b29c48c
chore: change log level to info
colin-axner 504aa0c
Merge branch 'colin/e2e-logging' of github.com:cosmos/ibc-go into col…
colin-axner 1ce1e55
Merge branch 'main' into colin/e2e-logging
colin-axner b37861d
Merge branch 'main' into cian/issue#3254-add-support-for-config-file-…
chatton 62ebe60
merge main
chatton c5ff4ae
cleaned up loading config from env
chatton 2d1a8c7
update to use damiannolan/rly image
chatton b879999
make init run before e2e test
chatton 69035aa
Merge branch 'colin/e2e-logging' into cian/issue#3254-add-support-for…
chatton fb99afc
add support for cometbft logging
chatton 163bafa
Merge branch 'main' into cian/issue#3254-add-support-for-config-file-…
chatton 6164983
merge main
chatton d6c1bd2
Merge branch 'main' into cian/issue#3254-add-support-for-config-file-…
chatton 36ea3c1
changed structure to yaml to enable comments in the config file
chatton b2fb47e
changed tags to yaml
chatton a022e9f
Merge branch 'main' into cian/issue#3254-add-support-for-config-file-…
chatton 99ccccc
cleaned up comment in config file
chatton 46caa85
Merge branch 'cian/issue#3254-add-support-for-config-file-for-running…
chatton f188d36
added option to force dump logs
chatton 0bee55f
Merge branch 'main' into cian/issue#3254-add-support-for-config-file-…
chatton 5c0b820
fixed e2e readme
chatton 03b11dc
correctly handle dumpLogs value
chatton 960b594
Merge branch 'main' into cian/issue#3254-add-support-for-config-file-…
chatton d6d13df
merge main
chatton f1d5a0f
Merge branch 'main' into cian/issue#3254-add-support-for-config-file-…
chatton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"chains": [ | ||
{ | ||
"chainId": "chain-a", | ||
"numValidators": 1, | ||
"numFullNodes": 0, | ||
"image": "ghcr.io/cosmos/ibc-go-simd", | ||
"tag": "main", | ||
"binary": "simd" | ||
}, | ||
{ | ||
"chainId": "chain-b", | ||
"numValidators": 1, | ||
"numFullNodes": 0, | ||
"image": "ghcr.io/cosmos/ibc-go-simd", | ||
"tag": "main", | ||
"binary": "simd" | ||
} | ||
], | ||
"relayer": { | ||
"type": "rly", | ||
"image": "damiannolan/rly", | ||
"tag": "latest" | ||
}, | ||
"cometbft": { | ||
"logLevel": "info" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we can tweak log level here now @colin-axner There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. black magic wizard |
||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
#!/bin/bash | ||
|
||
set -euo pipefail | ||
|
||
# ensure_config_file makes sure there is a config file for the e2e tests either by creating a new one using the sample, | ||
# it is copied to either the default location or the specified env location. | ||
function ensure_config_file(){ | ||
local config_file_path="${HOME}/.ibc-go-e2e-config.json" | ||
if [[ ! -z "${E2E_CONFIG_PATH:-}" ]]; then | ||
config_file_path="${E2E_CONFIG_PATH}" | ||
fi | ||
if [[ ! -f "${config_file_path}" ]]; then | ||
echo "creating e2e config file from sample." | ||
echo "copying sample.config.json to ${config_file_path}" | ||
cp sample.config.json "${config_file_path}" | ||
fi | ||
echo "using config file at ${config_file_path} for e2e test" | ||
} | ||
|
||
ensure_config_file |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addition of
init
here means we shouldn't need to do anything to get the default config created.