-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removing legacy params subspaces for sdk modules #3182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
This should be backported to v7.1.x only, right? |
Yep. The branch doesn't exist yet tho, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Yes, I haven't created it yet, just waiting a bit to see if we finally release v7 with or without localhost. But having the labels in the PRs already will make it easier to figure out later what needs to be backported.
But I don't think we should merge main into v7.1.x, otherwise we might bring some API breaking changes... |
(cherry picked from commit e9bc0ba)
Description
Removes params subspaces for sdk modules which have now migrated to self managed module params.
closes: #3141
Commit Message / Changelog Entry
chore: removing legacy params subspaces for sdk modules
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.