Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing legacy params subspaces for sdk modules #3182

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

damiannolan
Copy link
Member

Description

Removes params subspaces for sdk modules which have now migrated to self managed module params.

closes: #3141

Commit Message / Changelog Entry

chore: removing legacy params subspaces for sdk modules

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@crodriguezvega
Copy link
Contributor

This should be backported to v7.1.x only, right?

@damiannolan
Copy link
Member Author

damiannolan commented Feb 22, 2023

This should be backported to v7.1.x only, right?

Yep. The branch doesn't exist yet tho, right?
I thought the process was to branch off release/v7.0.x as release/v7.1.x and then merge main into the latter. I can add the label for v7.1.0 anyways!

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@damiannolan damiannolan merged commit e9bc0ba into main Feb 22, 2023
@damiannolan damiannolan deleted the damian/3141-remove-sdk-module-subspaces branch February 22, 2023 10:30
@crodriguezvega
Copy link
Contributor

I thought the process was to branch off release/v7.0.x as release/v7.1.x and then merge main into the latter. I can add the label for v7.1.0 anyways!

Yes, I haven't created it yet, just waiting a bit to see if we finally release v7 with or without localhost. But having the labels in the PRs already will make it easier to figure out later what needs to be backported.

then merge main into the latter

But I don't think we should merge main into v7.1.x, otherwise we might bring some API breaking changes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove params subspaces in simapp for sdk modules after v7
4 participants