Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scoped keeper interface for interchain app (backport #2035) #2361

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Add scoped keeper interface for interchain app (backport #2035) #2361

merged 2 commits into from
Sep 21, 2022

Commits on Sep 21, 2022

  1. Add scoped keeper interface for interchain app (#2035) 

    ## Description

Add scoped keeper interface for interchain app

Part of: #2020

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [ ] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes

(cherry picked from commit af96d43)

# Conflicts:
#	CHANGELOG.md
#	modules/apps/27-interchain-accounts/controller/keeper/keeper.go
#	modules/apps/27-interchain-accounts/host/keeper/keeper.go
    @Anmol1696 @mergify
    Anmol1696 authored and mergify[bot] committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    fa95340 View commit details
    Browse the repository at this point in the history

  2. resolving conflicts

    @damiannolan
    damiannolan committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    8d719d0 View commit details
    Browse the repository at this point in the history