Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change DefaultParams on the host to allow all messages ("*") #2290

Merged
merged 6 commits into from
Sep 21, 2022
Merged

change DefaultParams on the host to allow all messages ("*") #2290

merged 6 commits into from
Sep 21, 2022

Commits on Sep 14, 2022

  1. change DefaultParams on the host to allow all messages ("*") 

    Interchain Accounts are used by controller chains to execute transactions on the host chain. My suggestion is just as normal wallets are allowed to submit any transaction, by default, the host should allow all types of messages to be submitted using the ICAs. 

Allowing all messages by default makes more sense regarding the purpose of Interchain Accounts. 
Otherwise, it looks like this parameter should be configured to enable Interchain Accounts.
    @georgelombardi97
    georgelombardi97 authored Sep 14, 2022
    Configuration menu
    Copy the full SHA
    e7b8e32 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. correct formatting (gofumpt) 

    correct formatting (gofumpt)
    @georgelombardi97
    georgelombardi97 authored Sep 15, 2022
    Configuration menu
    Copy the full SHA
    2b211b9 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2022

  1. hold wildcard string in a constant

    george committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    e2de5ef View commit details
    Browse the repository at this point in the history

  2. add changelog

    george committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    80cb3af View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ICA-host-default-params-allow-all

    @crodriguezvega
    crodriguezvega authored Sep 21, 2022
    Configuration menu
    Copy the full SHA
    7550865 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into ICA-host-default-params-allow-all

    @colin-axner
    colin-axner authored Sep 21, 2022
    Configuration menu
    Copy the full SHA
    82256b6 View commit details
    Browse the repository at this point in the history