Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ica module to simulation manager #2252

Merged
merged 4 commits into from
Sep 14, 2022

Conversation

crodriguezvega
Copy link
Contributor

Description

Follow up from this comment.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@@ -604,6 +604,7 @@ func NewSimApp(
authzmodule.NewAppModule(appCodec, app.AuthzKeeper, app.AccountKeeper, app.BankKeeper, app.interfaceRegistry),
ibc.NewAppModule(app.IBCKeeper),
transfer.NewAppModule(app.TransferKeeper),
ica.NewAppModule(&app.ICAControllerKeeper, &app.ICAHostKeeper),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi :) look at this:

image

@codecov-commenter
Copy link

Codecov Report

Merging #2252 (f329d3e) into main (c2ce323) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2252      +/-   ##
==========================================
+ Coverage   79.51%   79.54%   +0.02%     
==========================================
  Files         175      175              
  Lines       12077    12069       -8     
==========================================
- Hits         9603     9600       -3     
+ Misses       2049     2045       -4     
+ Partials      425      424       -1     
Impacted Files Coverage Δ
...nterchain-accounts/controller/keeper/msg_server.go 100.00% <100.00%> (+8.33%) ⬆️
modules/apps/27-interchain-accounts/module.go 52.57% <0.00%> (+2.06%) ⬆️

@crodriguezvega crodriguezvega merged commit 80ea89a into main Sep 14, 2022
@crodriguezvega crodriguezvega deleted the carlos/add-ica-module-simulation-manager branch September 14, 2022 20:46
mergify bot pushed a commit that referenced this pull request Sep 14, 2022
Co-authored-by: colin axnér <[email protected]>
(cherry picked from commit 80ea89a)
mergify bot pushed a commit that referenced this pull request Sep 14, 2022
Co-authored-by: colin axnér <[email protected]>
(cherry picked from commit 80ea89a)
crodriguezvega added a commit that referenced this pull request Sep 15, 2022
Co-authored-by: colin axnér <[email protected]>
(cherry picked from commit 80ea89a)

Co-authored-by: Carlos Rodriguez <[email protected]>
crodriguezvega added a commit that referenced this pull request Sep 15, 2022
Co-authored-by: colin axnér <[email protected]>
(cherry picked from commit 80ea89a)

Co-authored-by: Carlos Rodriguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants